Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Implement automatic text track selection for 'metadata' tracks
https://bugs.webkit.org/show_bug.cgi?id=259581 rdar://problem/113004825 Reviewed by Eric Carlson. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=189185 Previously 'metadata' tracks were being configured using the "perform automatic text track selection" algorithm from the the spec, while it should only have applied step 4 of the "honor user preferences for automatic text track selection" algorithm. * Source/WebCore/html/HTMLMediaElement.cpp: (HTMLMediaElement::configureMetadataTextTrackGroup): function to handle 'metadata' as per spec (HTMLMediaElement::configureTextTrackGroup): for 'metadatatracks' use new function * Source/WebCore/html/HTMLMediaElement.h: Add definition for new function * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/266380@main
- Loading branch information
1 parent
ed55516
commit ec1a4f3
Showing
3 changed files
with
21 additions
and
3 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...embedded-content/media-elements/track/track-element/track-selection-metadata-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
|
||
FAIL Multiple 'metadata' tracks with 'default' assert_equals: expected "hidden" but got "showing" | ||
PASS Multiple 'metadata' tracks with 'default' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters