This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse the repository at this point in the history
Highlight logic incorrect for checking author set text color
https://bugs.webkit.org/show_bug.cgi?id=258943 rdar://111706100 Reviewed by Megan Gardner and Aditya Keerthi. Before logic to determine whether to take a text color of a StyledMarkedText was to compare to canvasText color. This causes aproblem if author set color to canvasText or if the color black was considered as canvasText. Now, we check if a flag was set indicating the author explicitly specified a text color. Updated TestExpectations due to passing test. Part of priority in spec: https://www.w3.org/TR/css-highlight-api-1/#priorities * LayoutTests/TestExpectations: * Source/WebCore/rendering/StyledMarkedText.cpp: (WebCore::resolveStyleForMarkedText): (WebCore::coalesceAdjacentWithSameRanges): * Source/WebCore/rendering/TextPaintStyle.cpp: (WebCore::computeTextSelectionPaintStyle): * Source/WebCore/rendering/TextPaintStyle.h: Canonical link: https://commits.webkit.org/266117@main
- Loading branch information
Showing 4 changed files with 6 additions and 4 deletions.