Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Web Inspector: should not include injected script host hooks in stack… 
… traces

https://bugs.webkit.org/show_bug.cgi?id=243319

Reviewed by Yusuke Suzuki.

* Source/JavaScriptCore/interpreter/StackVisitor.h:
* Source/JavaScriptCore/interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::isImplementationVisibilityPrivate const): Added.
* Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp:
(Inspector::CreateScriptCallStackFunctor::operator() const):
* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::GetStackTraceFunctor::operator() const):
(JSC::Interpreter::getStackTrace):
* Source/JavaScriptCore/runtime/Error.cpp:
(JSC::FindFirstCallerFrameWithCodeblockFunctor::operator() const):
If the `StackVisitor::Frame` doesn't have a `CodeBlock`, look at the `CalleeBits` to see if it has
an `ExecutableBase`, which can then be used to get the `ImplementationVisibility`.

* Source/JavaScriptCore/runtime/ExecutableBaseInlines.h:
(JSC::ExecutableBase::implementationVisibility const):
* Source/JavaScriptCore/runtime/NativeExecutable.h:
* Source/JavaScriptCore/runtime/NativeExecutable.cpp:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
* Source/JavaScriptCore/jit/JITThunks.h:
* Source/JavaScriptCore/jit/JITThunks.cpp:
(JSC::JITThunks::WeakNativeExecutableHash::hash):
(JSC::JITThunks::WeakNativeExecutableHash::equal):
(JSC::JITThunks::finalize):
(JSC::JITThunks::hostFunctionStub):
* Source/JavaScriptCore/runtime/VM.h:
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::getHostFunction):
(JSC::VM::getBoundFunction):
(JSC::VM::getRemoteFunction):
* Source/JavaScriptCore/runtime/JSFunction.h:
* Source/JavaScriptCore/runtime/JSFunction.cpp:
(JSC::JSFunction::create):
* Source/JavaScriptCore/runtime/JSObject.h:
* Source/JavaScriptCore/runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeIntrinsicGetter):
(JSC::JSObject::putDirectNativeIntrinsicGetterWithoutTransition):
(JSC::JSObject::putDirectNativeFunction):
(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
Require an `ImplementationVisibility` to create a `JSFunction`, which is passed along to the `NativeExecutable`.

* Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
* Source/JavaScriptCore/inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
Provide `ImplementationVisibility::Private` (new behavior) when creating any `JSFunction`.

* Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::init):
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_implementation.py:
(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_implementation.py:
(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):
* Source/JavaScriptCore/jsc.cpp:
(GlobalObject::finishCreation):
* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
* Source/JavaScriptCore/runtime/AtomicsObject.cpp:
(JSC::AtomicsObject::finishCreation):
* Source/JavaScriptCore/runtime/ConsoleObject.cpp:
(JSC::ConsoleObject::finishCreation):
* Source/JavaScriptCore/runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
* Source/JavaScriptCore/runtime/FinalizationRegistryPrototype.cpp:
(JSC::FinalizationRegistryPrototype::finishCreation):
* Source/JavaScriptCore/runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp:
(JSC::intlCollatorPrototypeGetterCompare):
* Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
(JSC::intlDateTimeFormatPrototypeGetterFormat):
* Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::finishCreation):
(JSC::intlNumberFormatPrototypeGetterFormat):
* Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::IntlObject::finishCreation):
* Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp:
(JSC::IntlPluralRulesPrototype::finishCreation):
* Source/JavaScriptCore/runtime/IntlSegmentsPrototype.cpp:
(JSC::IntlSegmentsPrototype::finishCreation):
* Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp:
(JSC::JSGenericArrayBufferConstructor<sharingMode>::finishCreation):
* Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
* Source/JavaScriptCore/runtime/JSCustomGetterFunction.cpp:
(JSC::JSCustomGetterFunction::create):
* Source/JavaScriptCore/runtime/JSCustomSetterFunction.cpp:
(JSC::JSCustomSetterFunction::create):
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::initStaticGlobals):
(JSC::JSGlobalObject::init):
* Source/JavaScriptCore/runtime/JSNativeStdFunction.cpp:
(JSC::JSNativeStdFunction::create):
* Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
* Source/JavaScriptCore/runtime/Lookup.h:
(JSC::reifyStaticProperty):
* Source/JavaScriptCore/runtime/Lookup.cpp:
(JSC::reifyStaticAccessor):
* Source/JavaScriptCore/runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
* Source/JavaScriptCore/runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
* Source/JavaScriptCore/runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
* Source/JavaScriptCore/runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
* Source/JavaScriptCore/runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
* Source/JavaScriptCore/runtime/ProxyConstructor.cpp:
(JSC::ProxyConstructor::finishCreation):
* Source/JavaScriptCore/runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
* Source/JavaScriptCore/runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
* Source/JavaScriptCore/runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
* Source/JavaScriptCore/runtime/SymbolPrototype.cpp:
(JSC::SymbolPrototype::finishCreation):
* Source/JavaScriptCore/runtime/WeakMapPrototype.cpp:
(JSC::WeakMapPrototype::finishCreation):
* Source/JavaScriptCore/runtime/WeakObjectRefPrototype.cpp:
(JSC::WeakObjectRefPrototype::finishCreation):
* Source/JavaScriptCore/runtime/WeakSetPrototype.cpp:
(JSC::WeakSetPrototype::finishCreation):
* Source/JavaScriptCore/tools/JSDollarVM.cpp:
(JSC::DOMJITGetterComplex::finishCreation):
(JSC::DOMJITFunctionObject::finishCreation):
(JSC::DOMJITCheckJSCastObject::finishCreation):
(JSC::WasmStreamingParser::finishCreation):
(JSC::WasmStreamingCompiler::finishCreation):
(JSC::functionCreateEmptyFunctionWithName):
(JSC::functionCreateBuiltin):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):
* Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::create):
* Source/JavaScriptCore/wasm/js/WebAssemblyGlobalPrototype.cpp:
(JSC::WebAssemblyGlobalPrototype::finishCreation):
* Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.cpp:
(JSC::WebAssemblyWrapperFunction::create):
* Source/WebCore/bindings/js/JSDOMAsyncIterator.h:
(WebCore::JSIterator>::finishCreation):
* Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
(WebCore::JSDOMGlobalObject::createCrossOriginFunction):
* Source/WebCore/bindings/js/JSDOMIterator.h:
(WebCore::IteratorTraits>::finishCreation):
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::showModalDialogGetter):
(WebCore::JSDOMWindow::openDatabase const):
* Source/WebCore/bindings/js/JSFileSystemDirectoryHandleIterator.cpp:
(WebCore::JSFileSystemDirectoryHandleIterator::createOnSettledFunction):
(WebCore::JSFileSystemDirectoryHandleIterator::createOnFulfilledFunction):
(WebCore::JSFileSystemDirectoryHandleIterator::createOnRejectedFunction):
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::JSTestGlobalObject::finishCreation):
* Source/WebCore/bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
* Source/WebCore/bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::finishCreation):
Provide `ImplementationVisibility::Public` (existing behavior) when creating any `JSFunction`.

* Source/WebInspectorUI/UserInterface/Controllers/StackTraceTreeController.js:
(WI.StackTraceTreeController.prototype._groupBlackboxedCallFrames):
Always display at least one call frame (or blackboxed group).

* Source/JavaScriptCore/runtime/NativeFunction.h:
(JSC::NativeFunctionHash::hash):
(JSC::TaggedNativeFunctionHash::hash):
(WTF::add): Added.
Allow `TaggedNativeFunctionHash` (and `NativeFunctionHash`) to work with `Hasher`.

* LayoutTests/inspector/animation/lifecycle-web-animation-expected.txt:
* LayoutTests/inspector/canvas/create-context-2d-expected.txt:
* LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt:
* LayoutTests/inspector/canvas/create-context-webgl-expected.txt:
* LayoutTests/inspector/canvas/create-context-webgl2-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-full-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-full-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-full-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-snapshots-expected.txt:
* LayoutTests/inspector/model/remote-object/error-expected.txt:
* LayoutTests/inspector/model/stack-trace-expected.txt:
* LayoutTests/inspector/timeline/line-column-expected.txt:
* LayoutTests/platform/gtk/inspector/timeline/line-column-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-frameCount-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-memoryLimit-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-frameCount-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-memoryLimit-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt:

Canonical link: https://commits.webkit.org/253022@main
  • Loading branch information
@dcrousso
dcrousso committed Aug 2, 2022
1 parent 5090cdf commit ec3feca
Show file tree
Hide file tree
Showing 99 changed files with 490 additions and 558 deletions.
1 change: 0 additions & 1 deletion LayoutTests/inspector/animation/lifecycle-web-animation-expected.txt
View file
Expand Up @@ -13,7 +13,6 @@ PASS: Animation created 'web-animation-test'.
0: setTimeout - [native code]
1: createAnimation - inspector/animation/resources/lifecycle-utilities.js:3:15
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
PASS: Animation type should be Web Animation.
startDelay: 100
endDelay: 200
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/inspector/canvas/create-context-2d-expected.txt
View file
Expand Up @@ -10,7 +10,6 @@ PASS: Canvas context should be 2D.
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -19,7 +18,6 @@ PASS: Canvas context should be 2D.
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -29,7 +27,6 @@ PASS: Canvas context should be 2D.
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

2 changes: 0 additions & 2 deletions LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt
View file
Expand Up @@ -10,7 +10,6 @@ PASS: Canvas context should be Bitmap Renderer.
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -19,7 +18,6 @@ PASS: Canvas context should be Bitmap Renderer.
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

3 changes: 0 additions & 3 deletions LayoutTests/inspector/canvas/create-context-webgl-expected.txt
View file
Expand Up @@ -10,7 +10,6 @@ PASS: Canvas context should be WebGL.
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -19,7 +18,6 @@ PASS: Canvas context should be WebGL.
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -29,7 +27,6 @@ PASS: Canvas context should be WebGL.
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

3 changes: 0 additions & 3 deletions LayoutTests/inspector/canvas/create-context-webgl2-expected.txt
View file
Expand Up @@ -10,7 +10,6 @@ PASS: Canvas context should be WebGL2.
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -19,7 +18,6 @@ PASS: Canvas context should be WebGL2.
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Removed canvas has expected ID.

Expand All @@ -29,7 +27,6 @@ PASS: Canvas context should be WebGL2.
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

2 changes: 0 additions & 2 deletions LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt
View file
Expand Up @@ -45,7 +45,6 @@ frames:
4: executeFrameFunction
5: performActions
6: Global Code
7: evaluateWithScopeExtension
1: arc(6, 7, 8, 9, 10, true)
swizzleTypes: [Number, Number, Number, Number, Number, Boolean]
trace:
Expand All @@ -56,5 +55,4 @@ frames:
4: executeFrameFunction
5: performActions
6: Global Code
7: evaluateWithScopeExtension

2 changes: 0 additions & 2 deletions LayoutTests/inspector/canvas/recording-2d-full-expected.txt
View file
Expand Up @@ -45,7 +45,6 @@ frames:
4: executeFrameFunction
5: performActions
6: Global Code
7: evaluateWithScopeExtension
1: arc(6, 7, 8, 9, 10, true)
swizzleTypes: [Number, Number, Number, Number, Number, Boolean]
trace:
Expand All @@ -56,7 +55,6 @@ frames:
4: executeFrameFunction
5: performActions
6: Global Code
7: evaluateWithScopeExtension
1: (duration)
0: arcTo(1, 2, 3, 4, 5)
swizzleTypes: [Number, Number, Number, Number, Number]
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt
View file
Expand Up @@ -45,5 +45,4 @@ frames:
4: executeFrameFunction
5: performActions
6: Global Code
7: evaluateWithScopeExtension

1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl-frameCount-expected.txt
View file
Expand Up @@ -20,5 +20,4 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension

1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl-full-expected.txt
View file
Expand Up @@ -20,7 +20,6 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension
1: (duration)
0: attachShader(0, 0)
swizzleTypes: [WebGLProgram, WebGLShader]
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl-memoryLimit-expected.txt
View file
Expand Up @@ -20,5 +20,4 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension

12 changes: 0 additions & 12 deletions LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt
View file
Expand Up @@ -18,23 +18,20 @@ frames:
0: useProgram
1: performActions
2: Global Code
3: evaluateWithScopeExtension
1: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
trace:
0: clearColor
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
2: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
3: bufferData(34962, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
Expand All @@ -43,15 +40,13 @@ frames:
1: drawArrays
2: performActions
3: Global Code
4: evaluateWithScopeExtension
4: drawArrays(4, 0, 3)
swizzleTypes: [Number, Number, Number]
trace:
0: drawArrays
1: drawArrays
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
5: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
Expand All @@ -60,15 +55,13 @@ frames:
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
6: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
7: bufferData(34962, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
Expand All @@ -77,23 +70,20 @@ frames:
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
8: bufferData(34963, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
trace:
0: bufferData
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
9: drawElements(4, 3, 5123, 0)
swizzleTypes: [Number, Number, Number, Number]
trace:
0: drawElements
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
10: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
Expand All @@ -102,14 +92,12 @@ frames:
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
11: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>

1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl2-frameCount-expected.txt
View file
Expand Up @@ -20,5 +20,4 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension

1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl2-full-expected.txt
View file
Expand Up @@ -20,7 +20,6 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension
1: (duration)
0: attachShader(0, 0)
swizzleTypes: [WebGLProgram, WebGLShader]
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/inspector/canvas/recording-webgl2-memoryLimit-expected.txt
View file
Expand Up @@ -20,5 +20,4 @@ frames:
2: executeFrameFunction
3: performActions
4: Global Code
5: evaluateWithScopeExtension

12 changes: 0 additions & 12 deletions LayoutTests/inspector/canvas/recording-webgl2-snapshots-expected.txt
View file
Expand Up @@ -18,23 +18,20 @@ frames:
0: useProgram
1: performActions
2: Global Code
3: evaluateWithScopeExtension
1: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
trace:
0: clearColor
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
2: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
3: bufferData(34962, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
Expand All @@ -43,15 +40,13 @@ frames:
1: drawArrays
2: performActions
3: Global Code
4: evaluateWithScopeExtension
4: drawArrays(4, 0, 3)
swizzleTypes: [Number, Number, Number]
trace:
0: drawArrays
1: drawArrays
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
5: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
Expand All @@ -60,15 +55,13 @@ frames:
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
6: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
7: bufferData(34962, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
Expand All @@ -77,23 +70,20 @@ frames:
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
8: bufferData(34963, 0, 35044)
swizzleTypes: [Number, TypedArray, Number]
trace:
0: bufferData
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
9: drawElements(4, 3, 5123, 0)
swizzleTypes: [Number, Number, Number, Number]
trace:
0: drawElements
1: drawElements
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>
10: clearColor(0, 0, 0, 1)
swizzleTypes: [Number, Number, Number, Number]
Expand All @@ -102,14 +92,12 @@ frames:
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
11: clear(16384)
swizzleTypes: [Number]
trace:
0: clear
1: clearContext
2: performActions
3: Global Code
4: evaluateWithScopeExtension
snapshot: <PASS: content changed>

6 changes: 3 additions & 3 deletions LayoutTests/inspector/model/remote-object/error-expected.txt
View file
Expand Up @@ -31,7 +31,7 @@ EXPRESSION: error = null; try { [].x.x; } catch (e) { error = e; }; error
{
"_name": "stack",
"_type": "string",
"_value": "global code@\nevaluateWithScopeExtension@[native code]"
"_value": "global code@"
}
],
"_entries": null
Expand Down Expand Up @@ -70,7 +70,7 @@ EXPRESSION: error = null; try { eval("if()"); } catch (e) { error = e; }; error
{
"_name": "stack",
"_type": "string",
"_value": "eval@[native code]\nglobal code@\nevaluateWithScopeExtension@[native code]"
"_value": "eval@[native code]\nglobal code@"
}
],
"_entries": null
Expand Down Expand Up @@ -104,7 +104,7 @@ EXPRESSION: error = null; try { document.createTextNode("").splitText(100); } ca
{
"_name": "stack",
"_type": "string",
"_value": "splitText@[native code]\nglobal code@\nevaluateWithScopeExtension@[native code]"
"_value": "splitText@[native code]\nglobal code@"
},
{
"_name": "code",
Expand Down

0 comments on commit ec3feca

Please sign in to comment.