Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):


Canonical link: https://commits.webkit.org/106223@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cswei committed Jun 6, 2012
1 parent 9616391 commit ec80557
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
13 changes: 13 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
2012-06-05 Charles Wei <charles.wei@torchmobile.com.cn>

Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):

2012-06-05 Michal Mocny <mmocny@google.com>

[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/bindings/js/JSIDBAnyCustom.cpp
Expand Up @@ -41,6 +41,7 @@
#include "IDBObjectStore.h"
#include "JSDOMStringList.h"
#include "JSIDBCursor.h"
#include "JSIDBCursorWithValue.h"
#include "JSIDBDatabase.h"
#include "JSIDBFactory.h"
#include "JSIDBIndex.h"
Expand Down Expand Up @@ -68,7 +69,7 @@ JSValue toJS(ExecState* exec, JSDOMGlobalObject* globalObject, IDBAny* idbAny)
case IDBAny::IDBCursorType:
return toJS(exec, globalObject, idbAny->idbCursor());
case IDBAny::IDBCursorWithValueType:
return toJS(exec, globalObject, idbAny->idbCursorWithValue());
return wrap<JSIDBCursorWithValue>(exec, globalObject, idbAny->idbCursorWithValue().get());
case IDBAny::IDBDatabaseType:
return toJS(exec, globalObject, idbAny->idbDatabase());
case IDBAny::IDBFactoryType:
Expand Down

0 comments on commit ec80557

Please sign in to comment.