Skip to content
Permalink
Browse files
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
        Reviewed by Timothy Hatcher.

        Web Inspector: Clicking on an error should take me to the error

        https://bugs.webkit.org/show_bug.cgi?id=34860

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype._selectTab):
        (WebInspector.ResourceView.prototype.selectContentTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.showResource):


Canonical link: https://commits.webkit.org/46833@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pavelfeldman committed Mar 4, 2010
1 parent 0866552 commit ecc2a7a9c401bb5e64a803a5ceb1b9be96114c9e
Showing 3 changed files with 19 additions and 3 deletions.
@@ -2,6 +2,21 @@

Reviewed by Timothy Hatcher.

Web Inspector: Clicking on an error should take me to the error

https://bugs.webkit.org/show_bug.cgi?id=34860

* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView):
(WebInspector.ResourceView.prototype._selectTab):
(WebInspector.ResourceView.prototype.selectContentTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showResource):

2010-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove sync access to resourceTrackingEnabled.

https://bugs.webkit.org/show_bug.cgi?id=35693
@@ -47,7 +47,7 @@ WebInspector.ResourceView = function(resource)
this.tabsElement.appendChild(this.contentTabElement);

this.headersTabElement.addEventListener("click", this._selectHeadersTab.bind(this), false);
this.contentTabElement.addEventListener("click", this._selectContentTab.bind(this), false);
this.contentTabElement.addEventListener("click", this.selectContentTab.bind(this), false);

this.headersElement = document.createElement("div");
this.headersElement.className = "resource-view-headers";
@@ -155,7 +155,7 @@ WebInspector.ResourceView.prototype = {
if (WebInspector.settings.resourceViewTab === "headers")
this._selectHeadersTab();
else
this._selectContentTab();
this.selectContentTab();
} else
this._innerSelectContentTab();
},
@@ -169,7 +169,7 @@ WebInspector.ResourceView.prototype = {
this.contentElement.addStyleClass("hidden");
},

_selectContentTab: function()
selectContentTab: function()
{
WebInspector.settings.resourceViewTab = "content";
this._innerSelectContentTab();
@@ -487,6 +487,7 @@ WebInspector.ResourcesPanel.prototype = {

var view = this.resourceViewForResource(resource);
view.headersVisible = true;
view.selectContentTab();
view.show(this.viewsContainerElement);

if (line) {

0 comments on commit ecc2a7a

Please sign in to comment.