Skip to content
Permalink
Browse files
[GTK] REGRESSION: Kinetic scrolling on touchpad doesn't work with asy…
…nc scrolling off

https://bugs.webkit.org/show_bug.cgi?id=224182

Patch by Alexander Mikhaylenko <alexm@gnome.org> on 2021-05-15
Reviewed by Michael Catanzaro.

Don't clear the scroll history every time we scroll, that defeats the whole point of having
the scroll history.

* platform/generic/ScrollAnimatorGeneric.cpp:
(WebCore::ScrollAnimatorGeneric::scrollToPositionWithoutAnimation):

Canonical link: https://commits.webkit.org/237767@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@277539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Exalm authored and webkit-commit-queue committed May 15, 2021
1 parent a51107f commit ee72e383e2b490d2e3cab07cd3fdad8daab59263
Showing with 13 additions and 1 deletion.
  1. +13 −0 Source/WebCore/ChangeLog
  2. +0 −1 Source/WebCore/platform/generic/ScrollAnimatorGeneric.cpp
@@ -1,3 +1,16 @@
2021-05-15 Alexander Mikhaylenko <alexm@gnome.org>

[GTK] REGRESSION: Kinetic scrolling on touchpad doesn't work with async scrolling off
https://bugs.webkit.org/show_bug.cgi?id=224182

Reviewed by Michael Catanzaro.

Don't clear the scroll history every time we scroll, that defeats the whole point of having
the scroll history.

* platform/generic/ScrollAnimatorGeneric.cpp:
(WebCore::ScrollAnimatorGeneric::scrollToPositionWithoutAnimation):

2021-05-15 Antti Koivisto <antti@apple.com>

Don't allow :visited link style in subtrees that use mix-blend-mode
@@ -65,7 +65,6 @@ ScrollAnimatorGeneric::~ScrollAnimatorGeneric() = default;
bool ScrollAnimatorGeneric::scrollToPositionWithoutAnimation(const FloatPoint& position, ScrollClamping clamping)
{
m_kineticAnimation->stop();
m_kineticAnimation->clearScrollHistory();
return ScrollAnimator::scrollToPositionWithoutAnimation(position, clamping);
}

0 comments on commit ee72e38

Please sign in to comment.