Skip to content
Permalink
Browse files
[Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
https://bugs.webkit.org/show_bug.cgi?id=229927

Reviewed by Don Olmstead.

TestWebKitAPI::Util::isKeyDown was not implemented

* TestWebKitAPI/CMakeLists.txt: Added Tests/WebKit/DidNotHandleKeyDown.cpp.
* TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp: GTK and WPE ports fail the test. Skip it.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Implemented.

Canonical link: https://commits.webkit.org/241425@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed Sep 8, 2021
1 parent e5cf82e commit ee9667cafadbcfc552569c1c504ee5b40ce55dec
Showing 4 changed files with 18 additions and 2 deletions.
@@ -1,3 +1,17 @@
2021-09-07 Fujii Hironori <Hironori.Fujii@sony.com>

[Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
https://bugs.webkit.org/show_bug.cgi?id=229927

Reviewed by Don Olmstead.

TestWebKitAPI::Util::isKeyDown was not implemented

* TestWebKitAPI/CMakeLists.txt: Added Tests/WebKit/DidNotHandleKeyDown.cpp.
* TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp: GTK and WPE ports fail the test. Skip it.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Implemented.

2021-09-07 Fujii Hironori <Hironori.Fujii@sony.com>

[Win] PlatformWebView::simulateSpacebarKeyPress sends wrong scan code for the space key and Alt key
@@ -253,6 +253,7 @@ if (ENABLE_WEBKIT)
Tests/WebKit/CanHandleRequest.cpp
Tests/WebKit/DOMWindowExtensionBasic.cpp
Tests/WebKit/DOMWindowExtensionNoCache.cpp
Tests/WebKit/DidNotHandleKeyDown.cpp
Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp
Tests/WebKit/DownloadDecideDestinationCrash.cpp
Tests/WebKit/EnumerateMediaDevices.cpp
@@ -26,6 +26,7 @@
#include "config.h"

#if WK_HAVE_C_SPI
#if PLATFORM(COCOA) || PLATFORM(WIN)

#include "JavaScriptTest.h"
#include "PlatformUtilities.h"
@@ -68,4 +69,5 @@ TEST(WebKit, DidNotHandleKeyDown)

} // namespace TestWebKitAPI

#endif // PLATFORM(COCOA) || PLATFORM(WIN)
#endif
@@ -62,8 +62,7 @@ WKURLRef URLForNonExistentResource()

bool isKeyDown(WKNativeEventPtr event)
{
// FIXME
return false;
return event->message == WM_KEYDOWN;
}

} // namespace Util

0 comments on commit ee9667c

Please sign in to comment.