Skip to content
Permalink
Browse files
Removing LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=165927

Reviewed by Daniel Bates.
Part 2

LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
simulators through simctl (iOS 10 and later), use this functionality instead.

Source/WebCore:

* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isDumpRenderTree): Update comment to reflect removal of LayoutTestRelay.

Tools:

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
Added a FIXME that we will need to implement similar archiving machinery once we build
ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
* BuildSlaveSupport/kill-old-processes:
(main): Remove LayoutTestRelay from list of processes.
* LayoutTestRelay: Removed LayoutTestRelay.
* Makefile:
* Scripts/build-layouttestrelay: Removed.
* Scripts/build-webkit: Removed LayoutTestRelay references.


Canonical link: https://commits.webkit.org/185189@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard committed Feb 10, 2017
1 parent 05bf8b1 commit efea931494f97e070a01846c0f359bdc15656f99
@@ -1,3 +1,17 @@
2017-02-10 Jonathan Bedard <jbedard@apple.com>

Removing LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=165927

Reviewed by Daniel Bates.
Part 2

LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
simulators through simctl (iOS 10 and later), use this functionality instead.

* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isDumpRenderTree): Update comment to reflect removal of LayoutTestRelay.

2017-02-10 Youenn Fablet <youenn@apple.com>

[WebRTC] Implement Outgoing libwebrtc audio source support
@@ -178,8 +178,8 @@ static bool applicationBundleIsEqualTo(const String& bundleIdentifierString)

bool IOSApplication::isDumpRenderTree()
{
// We use a prefix match instead of strict equality since LayoutTestRelay may launch multiple instances of
// DumpRenderTree where the bundle identifier of each instance has a unique suffix.
// We use a prefix match instead of strict equality since multiple instances of DumpRenderTree
// may be launched, where the bundle identifier of each instance has a unique suffix.
static bool isDumpRenderTree = applicationBundleIsEqualTo("org.webkit.DumpRenderTree"); // e.g. org.webkit.DumpRenderTree0
return isDumpRenderTree;
}
@@ -165,29 +165,9 @@ def dirContainsdwo(directory):
def archiveBuiltProduct(configuration, platform, fullPlatform):
assert platform in ('mac', 'win', 'gtk', 'efl', 'ios')

if fullPlatform.startswith('ios-simulator'):
# We need to include in the archive the Mac tool, LayoutTestRelay, to run layout tests in the iOS simulator.
combinedDirectory = os.path.join(_topLevelBuildDirectory, 'combined-mac-and-ios')
removeDirectoryIfExists(combinedDirectory)
os.makedirs(combinedDirectory)

if subprocess.call(['/bin/cp', '-pR', _configurationBuildDirectory, combinedDirectory]):
return 1

macBuildDirectory = webkitBuildDirectoryForConfigurationAndPlatform(configuration, 'mac')
destinationDirectory = os.path.join(combinedDirectory, os.path.relpath(macBuildDirectory, _topLevelBuildDirectory))
os.makedirs(destinationDirectory)
for filename in ['LayoutTestRelay', 'LayoutTestRelay.dSYM']:
sourceFile = os.path.join(macBuildDirectory, filename)
if not os.path.exists(sourceFile):
continue
if subprocess.call(['/bin/cp', '-pR', sourceFile, destinationDirectory]):
return 1

if createZip(combinedDirectory, configuration):
return 1
shutil.rmtree(combinedDirectory)
elif platform in ('mac', 'ios'):
# FIXME: ImageDiff should be built with the host SDK, <rdar://problem/30266038>.
# An approach similar to the one used for LayoutTestRelay in r190515 should be imlemented.
if platform in ('mac', 'ios'):
return createZip(_configurationBuildDirectory, configuration, embedParentDirectoryNameOnDarwin=True)
elif platform == 'win':
# FIXME: We shouldn't hardcode the assumption of a 32-bit build. See <https://bugs.webkit.org/show_bug.cgi?id=149715>.
@@ -90,7 +90,6 @@ def main():
"xcodebuild",
# FIXME: Consider moving iOS-specific tasks to their own list.
"Simulator",
"LayoutTestRelay"
]

taskToKillUnix = [
@@ -1,3 +1,25 @@
2017-02-10 Jonathan Bedard <jbedard@apple.com>

Removing LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=165927

Reviewed by Daniel Bates.
Part 2

LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
simulators through simctl (iOS 10 and later), use this functionality instead.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
Added a FIXME that we will need to implement similar archiving machinery once we build
ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
* BuildSlaveSupport/kill-old-processes:
(main): Remove LayoutTestRelay from list of processes.
* LayoutTestRelay: Removed LayoutTestRelay.
* Makefile:
* Scripts/build-layouttestrelay: Removed.
* Scripts/build-webkit: Removed LayoutTestRelay references.

2017-02-10 Jiewen Tan <jiewen_tan@apple.com>

[WebCrypto] Add WebCryptoAPI to watchlist

This file was deleted.

This file was deleted.

0 comments on commit efea931

Please sign in to comment.