Skip to content
Permalink
Browse files
2011-02-28 Adam Barth <abarth@webkit.org>
        Reviewed by Dimitri Glazkov.

        Teach JavaScriptGlue gyp build about DEPTH
        https://bugs.webkit.org/show_bug.cgi?id=55421

        Moves the previously JavaScriptGlue-specific GYP helper shell scripts
        to the gyp directory in Source, where they can be shared by multiple
        frameworks.

        * Source/gyp: Added.
        * Source/gyp/remove-headers-if-needed.sh: Copied from Source/JavaScriptGlue/gyp/remove-headers-if-needed.sh.
        * Source/gyp/run-if-exists.sh: Copied from Source/JavaScriptGlue/gyp/run-if-exists.sh.
        * Source/gyp/update-info-plist.sh: Copied from Source/JavaScriptGlue/gyp/update-info-plist.sh.
2011-02-28  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig & Darin Adler.

        Bug 55423 - Clean up property tables in Structure

        Encapsulate, reduce duplication of table search code,
        and reduce the size of the tables (remove the index,
        just maintain the tables in the correct order).

        Shows a 0.5% - 1% progression on sunspider.

        * ForwardingHeaders/wtf/HashTable.h: Added.


Canonical link: https://commits.webkit.org/69867@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Adam Barth committed Mar 1, 2011
1 parent 14f9490 commit f0d74b4ad9943d538f4d67e4e5d752ce14e4d93e
Showing 7 changed files with 53 additions and 14 deletions.
@@ -1,3 +1,19 @@
2011-02-28 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Teach JavaScriptGlue gyp build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55421

Moves the previously JavaScriptGlue-specific GYP helper shell scripts
to the gyp directory in Source, where they can be shared by multiple
frameworks.

* Source/gyp: Added.
* Source/gyp/remove-headers-if-needed.sh: Copied from Source/JavaScriptGlue/gyp/remove-headers-if-needed.sh.
* Source/gyp/run-if-exists.sh: Copied from Source/JavaScriptGlue/gyp/run-if-exists.sh.
* Source/gyp/update-info-plist.sh: Copied from Source/JavaScriptGlue/gyp/update-info-plist.sh.

2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.
@@ -12,6 +12,23 @@

* ForwardingHeaders/wtf/HashTable.h: Added.

2011-02-28 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Teach JavaScriptGlue gyp build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55421

After this path, we should set DEPTH to the Source directory, which is
a common point for all the frameworks that make up WebKit. These
changes to the GYP teach JavaScriptGlue how to find various files based
on DEPTH rather than based on the location of the xcodeproj file.

* gyp/JavaScriptGlue.gyp:
* gyp/remove-headers-if-needed.sh: Removed.
* gyp/run-if-exists.sh: Removed.
* gyp/update-info-plist.sh: Removed.

2011-02-28 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.
@@ -2,7 +2,7 @@
'includes': [
'JavaScriptGlue.gypi',
],
'xcode_config_file': '../Configurations/DebugRelease.xcconfig',
'xcode_config_file': '<(DEPTH)/JavaScriptGlue/Configurations/DebugRelease.xcconfig',
'targets': [
{
'target_name': 'JavaScriptGlue',
@@ -11,9 +11,9 @@
'Update Version'
],
'include_dirs': [
'..',
'../ForwardingHeaders',
'../icu',
'<(DEPTH)/JavaScriptGlue',
'<(DEPTH)/JavaScriptGlue/ForwardingHeaders',
'<(DEPTH)/JavaScriptGlue/icu',
'<(PRODUCT_DIR)/include',
],
'sources': [
@@ -35,25 +35,31 @@
{
'postbuild_name': 'Check For Global Initializers',
'action': [
'sh', 'run-if-exists.sh', 'check-for-global-initializers'
'sh', '<(DEPTH)/gyp/run-if-exists.sh', '<(DEPTH)/../Tools/Scripts/check-for-global-initializers'
],
},
{
'postbuild_name': 'Check For Weak VTables and Externals',
'action': [
'sh', 'run-if-exists.sh', 'check-for-weak-vtables-and-externals'
'sh', '<(DEPTH)/gyp/run-if-exists.sh', '<(DEPTH)/../Tools/Scripts/check-for-weak-vtables-and-externals'
],
},
{
'postbuild_name': 'Remove Headers If Needed',
'action': [
'sh', 'remove-headers-if-needed.sh'
'sh', '<(DEPTH)/gyp/remove-headers-if-needed.sh'
],
},
],
'conditions': [
['OS=="mac"', {
'mac_bundle': 1,
'xcode_settings': {
# FIXME: Remove these overrides once JavaScriptGlue.xcconfig is
# used only by this project.
'INFOPLIST_FILE': '<(DEPTH)/JavaScriptGlue/Info.plist',
'EXPORTED_SYMBOLS_FILE': '<(DEPTH)/JavaScriptGlue/JavaScriptGlue.exp',
},
}],
],
},
@@ -66,7 +72,7 @@
'inputs': [],
'outputs': [],
'action': [
'sh', 'update-info-plist.sh'
'sh', '<(DEPTH)/gyp/update-info-plist.sh', '<(DEPTH)/JavaScriptGlue/Info.plist'
],
},
], # actions

This file was deleted.

File renamed without changes.
@@ -0,0 +1,5 @@
#!/bin/sh

if [ -f $1 ]; then
$1 || exit $?;
fi
@@ -1,4 +1,4 @@
# Touch Info.plist to let Xcode know it needs to copy it into the built product
if [[ "${CONFIGURATION}" != "Production" ]]; then
touch "../Info.plist";
touch "$1";
fi

0 comments on commit f0d74b4

Please sign in to comment.