Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Entering full screen mode shows desktop linen instead of WKView the f…
…irst time.

https://bugs.webkit.org/show_bug.cgi?id=115433
<rdar://problem/13774540>

Reviewed by Eric Carlson.

For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

Canonical link: https://commits.webkit.org/133919@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jernoble committed May 1, 2013
1 parent 5da7ece commit f21e956
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,18 @@
2013-04-30 Jer Noble <jer.noble@apple.com>

Entering full screen mode shows desktop linen instead of WKView the first time.
https://bugs.webkit.org/show_bug.cgi?id=115433
<rdar://problem/13774540>

Reviewed by Eric Carlson.

For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

2013-05-01 Zoltan Arvai <zarvai@inf.u-szeged.hu>

[Qt][Win] Fix build after r149416.
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit2/UIProcess/API/mac/WKView.mm
Expand Up @@ -3394,7 +3394,7 @@ - (void)waitForAsyncDrawingAreaSizeUpdate
- (NSWindow*)createFullScreenWindow
{
#if ENABLE(FULLSCREEN_API)
return [[[WebCoreFullScreenWindow alloc] initWithContentRect:NSZeroRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
return [[[WebCoreFullScreenWindow alloc] initWithContentRect:[[NSScreen mainScreen] frame] styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
#else
return nil;
#endif
Expand Down

0 comments on commit f21e956

Please sign in to comment.