Skip to content
Permalink
Browse files
stress/intl-datetimeformat-formatrange.js and stress/intl-datetimefor…
…mat-formatrange-relevant-extensions.js fail with ICU 65.1

https://bugs.webkit.org/show_bug.cgi?id=218763

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-11-10
Reviewed by Yusuke Suzuki.

Yesterday Red Hat upgraded its internal CI to Fedora 32 (ICU 65.1), causing
stress/intl-datetimeformat-formatrange-relevant-extensions.js and
stress/intl-datetimeformat-formatrange.js to begin failing. The problem is that the space
characters used in the range format changed at some point. The current version of the test
expects normal ASCII space characters for ICU 67 and newer, and special spaces for older
versions of ICU.

The test passes for me locally on Fedora 33 (ICU 67.1), so perhaps we just need to use the
new codepath for ICU 65 and 66 as well.

* stress/intl-datetimeformat-formatrange-relevant-extensions.js:
* stress/intl-datetimeformat-formatrange.js:
(test):

Canonical link: https://commits.webkit.org/231448@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mcatanzaro authored and webkit-commit-queue committed Nov 11, 2020
1 parent b751543 commit f40b60b98ab3a00fa3359f0b9a75bda772260c79
Showing 3 changed files with 25 additions and 4 deletions.
@@ -1,3 +1,24 @@
2020-11-10 Michael Catanzaro <mcatanzaro@gnome.org>

stress/intl-datetimeformat-formatrange.js and stress/intl-datetimeformat-formatrange-relevant-extensions.js fail with ICU 65.1
https://bugs.webkit.org/show_bug.cgi?id=218763

Reviewed by Yusuke Suzuki.

Yesterday Red Hat upgraded its internal CI to Fedora 32 (ICU 65.1), causing
stress/intl-datetimeformat-formatrange-relevant-extensions.js and
stress/intl-datetimeformat-formatrange.js to begin failing. The problem is that the space
characters used in the range format changed at some point. The current version of the test
expects normal ASCII space characters for ICU 67 and newer, and special spaces for older
versions of ICU.

The test passes for me locally on Fedora 33 (ICU 67.1), so perhaps we just need to use the
new codepath for ICU 65 and 66 as well.

* stress/intl-datetimeformat-formatrange-relevant-extensions.js:
* stress/intl-datetimeformat-formatrange.js:
(test):

2020-11-09 Keith Miller <keith_miller@apple.com>

Add microbenchmark for FinalizationRegistry basic usage
@@ -19,8 +19,8 @@ function shouldThrow(func, errorMessage) {
}

function test() {
let range = " – "; // This is not usual space unfortuantely in ICU 66.
if ($vm.icuVersion() > 66)
let range = " – "; // This is not usual space unfortuantely in older ICU versions.
if ($vm.icuVersion() >= 65)
range = " – ";

let date1 = new Date(Date.UTC(2007, 0, 10, 10, 0, 0));
@@ -33,8 +33,8 @@ shouldThrow(() => {


function test() {
let range = " – "; // This is not usual space unfortuantely in ICU 66.
if ($vm.icuVersion() > 66)
let range = " – "; // This is not usual space unfortuantely in older ICU versions.
if ($vm.icuVersion() >= 65)
range = " – ";

let date1 = new Date(Date.UTC(2007, 0, 10, 10, 0, 0));

0 comments on commit f40b60b

Please sign in to comment.