Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix failing mediasource-play.html and mediasource-config-change-mp4-v…
…-bitrate.html tests https://bugs.webkit.org/show_bug.cgi?id=161819 Reviewed by Eric Carlson. Source/WebCore: Fixes tests: imported/w3c/web-platform-tests/media-source/mediasource-play.html imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode.html The newest revision of the web-platform-test suite for Media Source tests new behavior added to the MSE specification. Specifically, setting a MediaSource's duration will no longer implicitly truncate the source's active SourceBuffer objects. * Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::setDuration): Return exception if issued by setDurationInternal. (WebCore::MediaSource::setDurationInternal): Bring "duration change" algorithm up to spec. * Modules/mediasource/MediaSource.h: * Modules/mediasource/SampleMap.h: (WebCore::PresentationOrderSampleMap::begin): Add const accessor. (WebCore::PresentationOrderSampleMap::end): Ditto. (WebCore::PresentationOrderSampleMap::rbegin): Ditto. (WebCore::PresentationOrderSampleMap::rend): DItto. (WebCore::DecodeOrderSampleMap::begin): Ditto. (WebCore::DecodeOrderSampleMap::end): Ditto. (WebCore::DecodeOrderSampleMap::rbegin): Ditto. (WebCore::DecodeOrderSampleMap::rend): Ditto. * Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::highestPresentationTimestamp): Added convenience method. (WebCore::SourceBuffer::removeCodedFrames): Drive-by fix; use .values() rather than pulling the value out of each HashMap iterator. * Modules/mediasource/SourceBuffer.h: LayoutTests: * media/media-source/media-source-end-of-stream-readyState.html: * media/media-source/media-source-end-of-stream-readyState-expected.txt: * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/180023@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@205820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
110 additions
and 32 deletions.
- +11 −0 LayoutTests/ChangeLog
- +1 −1 LayoutTests/media/media-source/media-source-end-of-stream-readyState-expected.txt
- +2 −1 LayoutTests/media/media-source/media-source-end-of-stream-readyState.html
- +2 −1 LayoutTests/platform/mac/TestExpectations
- +33 −0 Source/WebCore/ChangeLog
- +33 −25 Source/WebCore/Modules/mediasource/MediaSource.cpp
- +1 −1 Source/WebCore/Modules/mediasource/MediaSource.h
- +12 −0 Source/WebCore/Modules/mediasource/SampleMap.h
- +13 −3 Source/WebCore/Modules/mediasource/SourceBuffer.cpp
- +2 −0 Source/WebCore/Modules/mediasource/SourceBuffer.h
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters