Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[Tests] Unskip not failing tests previously relying on LTC::nodesFrom…
…Rect implementation

https://bugs.webkit.org/show_bug.cgi?id=46600

Reviewed by Ryosuke Niwa.

These tests no longer relies on LayoutTestController.nodesFromRect but on Internals, and should work
in all platforms.

* platform/chromium/TestExpectations:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:


Canonical link: https://commits.webkit.org/109140@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Allan Sandfeld Jensen committed Jul 14, 2012
1 parent 4256c85 commit f82db10
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 14 deletions.
15 changes: 15 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,18 @@
2012-07-14 Allan Sandfeld Jensen <allan.jensen@nokia.com>

[Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation
https://bugs.webkit.org/show_bug.cgi?id=46600

Reviewed by Ryosuke Niwa.

These tests no longer relies on LayoutTestController.nodesFromRect but on Internals, and should work
in all platforms.

* platform/chromium/TestExpectations:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

2012-07-14 Robert Hogan <robert@webkit.org>

Skip test added in r122663 on Qt and GTK
Expand Down
6 changes: 1 addition & 5 deletions LayoutTests/platform/chromium/TestExpectations
Expand Up @@ -2153,13 +2153,9 @@ BUGCR58735 SLOW : http/tests/misc/prefetch-purpose.html = PASS
BUGCR58936 : fast/js/basic-strict-mode.html = TEXT
BUGCR58936 : fast/js/numeric-escapes-in-string-literals.html = TEXT

// These used to depend on layoutTestController.nodesFromRect, but could probably be unskipped now.
BUGWK46600 SKIP : fast/dom/nodesFromRect/nodesFromRect-links-and-text.html = TEXT
BUGWK46600 SKIP : fast/dom/nodesFromRect/nodesFromRect-inner-documents.html = TEXT

// For some reason it seems to not properly rect hit-tests elements in shadow
// content of <video> elements.
BUGWK46600 SKIP : media/nodesFromRect-shadowContent.html = TEXT
BUGWK91205 SKIP : media/nodesFromRect-shadowContent.html = TEXT

BUGJAMESR LINUX WIN : fast/text/international/vertical-text-glyph-test.html = IMAGE+TEXT
BUGJAMESR LINUX WIN : fast/text/international/vertical-text-metrics-test.html = TEXT
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/win/Skipped
Expand Up @@ -1301,9 +1301,6 @@ http/tests/websocket/tests/hybi/send-file-blob.html
http/tests/websocket/tests/hybi/send-file-blob-fail.html
fast/mutation/filesystem-callback-delivery.html

# Tests skipped for historical reasons, should be unskipped.
fast/dom/nodesFromRect

# https://bugs.webkit.org/show_bug.cgi?id=46223
# The WebKit plugin implementation does not support iframe shims.
plugins/iframe-shims.html
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/wincairo/Skipped
Expand Up @@ -1816,9 +1816,6 @@ http/tests/websocket/tests/hybi/send-file-blob-fail.html
fast/mutation/filesystem-callback-delivery.html
fast/forms/file/input-file-entries.html

# Tests skipped for historical reasons, should be unskipped.
fast/dom/nodesFromRect

# https://bugs.webkit.org/show_bug.cgi?id=46223
# The WebKit plugin implementation does not support iframe shims.
plugins/iframe-shims.html
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/wk2/Skipped
Expand Up @@ -899,9 +899,6 @@ platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
# WebKitTestRunner needs layoutTestController.hasGrammarMarker
editing/spelling/grammar.html

# Tests skipped for historical reasons, should be unskipped.
fast/dom/nodesFromRect

# WebKitTestRunner needs layoutTestController.setSpatialNavigationEnabled
fast/spatial-navigation

Expand Down

0 comments on commit f82db10

Please sign in to comment.