Skip to content
Permalink
Browse files
2010-10-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix an assert with QtPixmapInstance creation.
        https://bugs.webkit.org/show_bug.cgi?id=48323

        This places the newly refcounted QtPixmapInstance in a RefPtr
        to prevent an assert on the first ref() call.

        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):

Canonical link: https://commits.webkit.org/61089@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jturcotte committed Oct 26, 2010
1 parent b8c5ff7 commit f84693f773973e86a684743a2a8dc96888594cd0
Showing 2 changed files with 14 additions and 1 deletion.
@@ -1,3 +1,16 @@
2010-10-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix an assert with QtPixmapInstance creation.
https://bugs.webkit.org/show_bug.cgi?id=48323

This places the newly refcounted QtPixmapInstance in a RefPtr
to prevent an assert on the first ref() call.

* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):

2010-10-26 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.
@@ -355,7 +355,7 @@ RuntimeObject* QtPixmapInstance::newRuntimeObject(ExecState* exec)
JSObject* QtPixmapInstance::createPixmapRuntimeObject(ExecState* exec, PassRefPtr<RootObject> root, const QVariant& data)
{
JSLock lock(SilenceAssertionsOnly);
QtPixmapInstance* instance = new QtPixmapInstance(root, data);
RefPtr<QtPixmapInstance> instance = adoptRef(new QtPixmapInstance(root, data));
return instance->createRuntimeObject(exec);
}

0 comments on commit f84693f

Please sign in to comment.