Skip to content
Permalink
Browse files
ServiceWorkerJob::m_lastResponse is unneeded
https://bugs.webkit.org/show_bug.cgi?id=183013

Patch by Youenn Fablet <youenn@apple.com> on 2018-02-21
Reviewed by Chris Dumez.

Remove this field since not used anywhere.

* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::didReceiveResponse):
* workers/service/ServiceWorkerJob.h:

Canonical link: https://commits.webkit.org/198770@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf authored and webkit-commit-queue committed Feb 21, 2018
1 parent 74d27f7 commit f8924f7918ae2f894622040133c41df648342af4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
@@ -1,3 +1,16 @@
2018-02-21 Youenn Fablet <youenn@apple.com>

ServiceWorkerJob::m_lastResponse is unneeded
https://bugs.webkit.org/show_bug.cgi?id=183013

Reviewed by Chris Dumez.

Remove this field since not used anywhere.

* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::didReceiveResponse):
* workers/service/ServiceWorkerJob.h:

2018-02-21 Youenn Fablet <youenn@apple.com>

Use ResourceLoader to load appcache manifest
@@ -107,7 +107,6 @@ void ServiceWorkerJob::didReceiveResponse(unsigned long, const ResourceResponse&
ASSERT(!m_completed);
ASSERT(m_scriptLoader);

m_lastResponse = response;
// Extract a MIME type from the response's header list. If this MIME type (ignoring parameters) is not a JavaScript MIME type, then:
if (!MIMETypeRegistry::isSupportedJavaScriptMIMEType(response.mimeType())) {
// Invoke Reject Job Promise with job and "SecurityError" DOMException.
@@ -89,7 +89,6 @@ class ServiceWorkerJob : public ThreadSafeRefCounted<ServiceWorkerJob>, public W

DocumentOrWorkerIdentifier m_contextIdentifier;
RefPtr<WorkerScriptLoader> m_scriptLoader;
ResourceResponse m_lastResponse;

#if !ASSERT_DISABLED
Ref<Thread> m_creationThread { Thread::current() };

0 comments on commit f8924f7

Please sign in to comment.