Skip to content
Permalink
Browse files
-Wstringop-overflow warning in DocumentWriter.cpp
https://bugs.webkit.org/show_bug.cgi?id=239340

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2022-05-13
Reviewed by Chris Dumez.

* Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end):

Canonical link: https://commits.webkit.org/250533@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mcatanzaro authored and webkit-commit-queue committed May 13, 2022
1 parent 00de4db commit f93f550572f580c1242c7db978aabf37e5815790
Showing with 13 additions and 0 deletions.
  1. +11 −0 Source/WebCore/ChangeLog
  2. +2 −0 Source/WebCore/loader/DocumentWriter.cpp
@@ -1,3 +1,14 @@
2022-05-13 Michael Catanzaro <mcatanzaro@redhat.com>

-Wstringop-overflow warning in DocumentWriter.cpp
https://bugs.webkit.org/show_bug.cgi?id=239340
<rdar://problem/93243931>

Reviewed by Chris Dumez.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end):

2022-05-13 Ziran Sun <zsun@igalia.com>

input.showPicker() should throw when input is readonly/disabled
@@ -296,7 +296,9 @@ void DocumentWriter::end()
// http://bugs.webkit.org/show_bug.cgi?id=10854
// The frame's last ref may be removed and it can be deleted by checkCompleted(),
// so we'll add a protective refcount
IGNORE_GCC_WARNINGS_BEGIN("stringop-overflow")
Ref<Frame> protect(*m_frame);
IGNORE_GCC_WARNINGS_END

if (!m_parser)
return;

0 comments on commit f93f550

Please sign in to comment.