Skip to content
Permalink
Browse files
Make fast/text/complex-initial-advance.html more robust
https://bugs.webkit.org/show_bug.cgi?id=202708
<rdar://problem/49539493>

Reviewed by Tim Horton.

We are hitting floating point precision issues. Fortunately, the part of the text that is
hitting these issues isn't actually necessary for the test.

* fast/text/complex-initial-advance-expected.html:
* fast/text/complex-initial-advance.html:
* platform/mac/TestExpectations:


Canonical link: https://commits.webkit.org/216188@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
litherum committed Oct 9, 2019
1 parent bb09dab commit fbe2bd71be4dd8680ca30aef89b638f205f0de13
@@ -1,3 +1,18 @@
2019-10-08 Myles C. Maxfield <mmaxfield@apple.com>

Make fast/text/complex-initial-advance.html more robust
https://bugs.webkit.org/show_bug.cgi?id=202708
<rdar://problem/49539493>

Reviewed by Tim Horton.

We are hitting floating point precision issues. Fortunately, the part of the text that is
hitting these issues isn't actually necessary for the test.

* fast/text/complex-initial-advance-expected.html:
* fast/text/complex-initial-advance.html:
* platform/mac/TestExpectations:

2019-10-08 Devin Rousso <drousso@apple.com>

Web Inspector: Canvas: modifications to shader modules can be shared between vertex/fragment shaders
@@ -4,6 +4,7 @@
<meta charset="utf-8">
</head>
<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
<span>مليئ حياةٍ مليئ</span>
<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the &#x25CC;&#x064D; marks are positioned in the right place below the &#x0629; character below.</div>
<span>حياةٍ مليئ</span>
</body>
</html>
@@ -4,6 +4,7 @@
<meta charset="utf-8">
</head>
<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
<span>مليئ</span><span> </span><span>حياةٍ</span><span> </span><span>مليئ</span>
<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the &#x25CC;&#x064D; marks are positioned in the right place below the &#x0629; character below.</div>
<span>حياةٍ</span><span> </span><span>مليئ</span>
</body>
</html>
@@ -1814,8 +1814,6 @@ imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001.h

webkit.org/b/19650 [ HighSierra+ ] accessibility/mac/press-not-work-for-disabled-menu-list.html [ Pass Failure ]

webkit.org/b/196512 [ Mojave+ ] fast/text/complex-initial-advance.html [ ImageOnlyFailure ]

webkit.org/b/196517 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html [ Skip ]

webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]
@@ -2041,4 +2039,4 @@ webkit.org/b/202516 imported/w3c/web-platform-tests/2dcontext/path-objects/2d.pa

webkit.org/b/202523 imported/w3c/web-platform-tests/2dcontext/path-objects/2d.path.stroke.scale2.html [ Failure ]

webkit.org/b/202598 imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html [ Failure ]
webkit.org/b/202598 imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html [ Failure ]

0 comments on commit fbe2bd7

Please sign in to comment.