Skip to content

Commit

Permalink
Update DOMException name: URLMismatchError
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=102511

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 21 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:
(WebCore):

LayoutTests:

Updated tests and expectations.

* fast/workers/shared-worker-shared-expected.txt:


Canonical link: https://commits.webkit.org/120835@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
arv committed Nov 19, 2012
1 parent 28e6641 commit fd6a0ac
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 2 deletions.
11 changes: 11 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
2012-11-19 Erik Arvidsson <arv@chromium.org>

Update DOMException name: URLMismatchError
https://bugs.webkit.org/show_bug.cgi?id=102511

Reviewed by Kentaro Hara.

Updated tests and expectations.

* fast/workers/shared-worker-shared-expected.txt:

2012-11-19 Csaba Osztrogonác <ossy@webkit.org>

[Qt][WK2] Unreviewed gardening, unskip a now passing test.
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/fast/workers/shared-worker-shared-expected.txt
@@ -1,6 +1,6 @@
Test simple shared worker sharing cases. Should print several PASS lines followed by DONE.

PASS: Exception thrown when creating SharedWorker with different URLs but same name: Error: URL_MISMATCH_ERR: DOM Exception 21
PASS: Exception thrown when creating SharedWorker with different URLs but same name: Error: URLMismatchError: DOM Exception 21
PASS: Accessing new instance of shared worker: self.foo: undefined
PASS: Setting global variable in shared worker: self.foo = 1234: 1234
PASS: Accessing simultaneously-loaded instance of shared worker: self.foo: 1234
Expand Down
14 changes: 14 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
2012-11-19 Erik Arvidsson <arv@chromium.org>

Update DOMException name: URLMismatchError
https://bugs.webkit.org/show_bug.cgi?id=102511

Reviewed by Kentaro Hara.

Patch 21 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:
(WebCore):

2012-11-19 Kihong Kwon <kihong.kwon@samsung.com>

Add PROXIMITY_EVENTS feature
Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/dom/DOMCoreException.cpp
Expand Up @@ -56,7 +56,7 @@ static struct CoreException {
// FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR
{ "NetworkError", "A network error occurred." },
{ "AbortError", "The user aborted a request." },
{ "URL_MISMATCH_ERR", "A worker global scope represented an absolute URL that is not equal to the resulting absolute URL." },
{ "URLMismatchError", "A worker global scope represented an absolute URL that is not equal to the resulting absolute URL." },
{ "QuotaExceededError", "An attempt was made to add something to storage that exceeded the quota." },
{ "TIMEOUT_ERR", "A timeout occurred." },
{ "INVALID_NODE_TYPE_ERR", "The supplied node is invalid or has an invalid ancestor for this operation." },
Expand Down

0 comments on commit fd6a0ac

Please sign in to comment.