Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Scrolling with page granularity using keyboard smooth scrolling doesn…
…'t account for fixed content https://bugs.webkit.org/show_bug.cgi?id=245746 rdar://100469555 Reviewed by Tim Horton. When keyboard smooth scrolling is enabled, `KeyboardScrollingAnimator::scrollDistance` is used, which is analagous to `ScrollableArea::scroll`. However, while the latter accounts for page's having fixed content when scrolling with page granularity, the former never does. This PR fixes this by including the same logic that `ScrollableArea::scroll` has to adjust the scroll step into `KeyboardScrollingAnimator::scrollDistance`. * LayoutTests/scrollbars/scrolling-backward-by-page-accounting-bottom-fixed-elements-on-keyboard-spacebar.html: * Source/WebCore/platform/KeyboardScrollingAnimator.cpp: (WebCore::KeyboardScrollingAnimator::scrollDistance const): * Source/WebCore/platform/ScrollableArea.h: Canonical link: https://commits.webkit.org/254963@main
- Loading branch information
Showing 3 changed files with 25 additions and 13 deletions.