Skip to content
Permalink
Browse files
[Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=206582
<rdar://problem/58985368>

Unreviewed.


* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::initialize):
Allow deprecation warnings.


Canonical link: https://commits.webkit.org/225631@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf committed Jun 5, 2020
1 parent 26ddb88 commit fe3e07bdf012c205fbf68f602bc11e93c0fcd992
Showing with 14 additions and 0 deletions.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +2 −0 Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm
@@ -1,3 +1,15 @@
2020-06-05 Youenn Fablet <youenn@apple.com>

[Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=206582
<rdar://problem/58985368>

Unreviewed.

* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::initialize):
Allow deprecation warnings.

2020-06-05 Michael Catanzaro <mcatanzaro@gnome.org>

Unreviewed, fix unused parameter warnings in EventRegion.cpp and RenderLayerBacking.cpp
@@ -159,7 +159,9 @@ - (void)close
bool MediaRecorderPrivateWriter::initialize()
{
NSError *error = nil;
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
m_writer = adoptNS([PAL::allocAVAssetWriterInstance() initWithFileType:AVFileTypeMPEG4 error:&error]);
ALLOW_DEPRECATED_DECLARATIONS_END
if (error) {
RELEASE_LOG_ERROR(MediaStream, "create AVAssetWriter instance failed with error code %ld", (long)error.code);
return false;

0 comments on commit fe3e07b

Please sign in to comment.