Skip to content
Permalink
Browse files
Disable URL scheme check in Data Detectors for all clients
https://bugs.webkit.org/show_bug.cgi?id=241273

Reviewed by Geoffrey Garen.

We are seeing telmetry where also Web browser clients are attempting to connect to Launch Services when data detection
is trying to find an application to handle a URL with a custom scheme. Since Launch Services is blocked in the sandbox,
the WebContent process will be unable to determine if there is an application that can open this URL, and the link will
not be clickable. This can be addressed by disabling the URL scheme check in Data Detectors for all clients.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/251458@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pvollan committed Jun 10, 2022
1 parent fc784f4 commit fee86243266220ed87f0d791a6df4e27d60998ab
Showing 1 changed file with 1 addition and 2 deletions.
@@ -431,8 +431,7 @@ static void softlinkDataDetectorsFrameworks()

accessibilityPreferencesDidChange(parameters.accessibilityPreferences);

if (!isParentProcessAFullWebBrowser(*this))
disableURLSchemeCheckInDataDetectors();
disableURLSchemeCheckInDataDetectors();

// Soft link frameworks related to Data Detection before we disconnect from launchd because these frameworks connect to
// launchd temporarily at link time to register XPC services. See rdar://93598951 (my feature request to stop doing that)

0 comments on commit fee8624

Please sign in to comment.