Skip to content
Permalink
Browse files
[Qt] Add setSpatialNavigationEnabled method DRT
https://bugs.webkit.org/show_bug.cgi?id=33715

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Added setSpatialNavigationEnabled support to Qt DRT.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatial-navigation/

Canonical link: https://commits.webkit.org/46877@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Antonio Gomes committed Mar 5, 2010
1 parent 049a1a5 commit ff09574a6630a7a76d5ecfbaaeb4768584537d0f
Showing 5 changed files with 25 additions and 3 deletions.
@@ -5095,6 +5095,3 @@ java
# see https://bugs.webkit.org/show_bug.cgi?id=33180.
# Core functionality is tested in plugins/private-browsing-mode-2.html
plugins/private-browsing-mode.html

# Need to add functionality to DumpRenderTree to handle enable/disable Spatial Navigation
fast/events/spatial-navigation
@@ -1,3 +1,20 @@
2010-03-02 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>

[Qt] Add setSpatialNavigationEnabled method DRT
https://bugs.webkit.org/show_bug.cgi?id=33715

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatialnavigation/

2010-03-04 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Alice Liu.
@@ -132,6 +132,7 @@ WebPage::WebPage(QObject* parent, DumpRenderTree* drt)
globalSettings->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, true);
globalSettings->setAttribute(QWebSettings::JavascriptEnabled, true);
globalSettings->setAttribute(QWebSettings::PrivateBrowsingEnabled, false);
globalSettings->setAttribute(QWebSettings::SpatialNavigationEnabled, false);

connect(this, SIGNAL(geometryChangeRequested(const QRect &)),
this, SLOT(setViewGeometry(const QRect & )));
@@ -162,6 +163,7 @@ void WebPage::resetSettings()
settings()->resetAttribute(QWebSettings::JavascriptCanOpenWindows);
settings()->resetAttribute(QWebSettings::JavascriptEnabled);
settings()->resetAttribute(QWebSettings::PrivateBrowsingEnabled);
settings()->resetAttribute(QWebSettings::SpatialNavigationEnabled);
settings()->resetAttribute(QWebSettings::LinksIncludedInFocusChain);
settings()->resetAttribute(QWebSettings::OfflineWebApplicationCacheEnabled);
settings()->resetAttribute(QWebSettings::LocalContentCanAccessRemoteUrls);
@@ -344,6 +344,11 @@ void LayoutTestController::setPrivateBrowsingEnabled(bool enable)
m_drt->webPage()->settings()->setAttribute(QWebSettings::PrivateBrowsingEnabled, enable);
}

void LayoutTestController::setSpatialNavigationEnabled(bool enable)
{
m_drt->webPage()->settings()->setAttribute(QWebSettings::SpatialNavigationEnabled, enable);
}

void LayoutTestController::setPopupBlockingEnabled(bool enable)
{
m_drt->webPage()->settings()->setAttribute(QWebSettings::JavascriptCanOpenWindows, !enable);
@@ -128,6 +128,7 @@ public slots:
void setTimelineProfilingEnabled(bool enable);
void setFixedContentsSize(int width, int height);
void setPrivateBrowsingEnabled(bool enable);
void setSpatialNavigationEnabled(bool enabled);
void setPopupBlockingEnabled(bool enable);
void setPOSIXLocale(const QString& locale);
void resetLoadFinished() { m_loadFinished = false; }

0 comments on commit ff09574

Please sign in to comment.