Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
AudioParam's minValue / maxValue are ignored
https://bugs.webkit.org/show_bug.cgi?id=215905

Reviewed by Darin Adler.

Source/WebCore:

Clamp the AudioParam's values so that they are always in the
[minValue, maxValue] range.

Test: webaudio/audioparam-nominal-range.html

* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::value):
(WebCore::AudioParam::setValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):
* Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
* Modules/webaudio/AudioParamTimeline.h:
* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):

LayoutTests:

Import layout test coverage from Blink.

* webaudio/audioparam-nominal-range-expected.txt: Added.
* webaudio/audioparam-nominal-range.html: Added.


Canonical link: https://commits.webkit.org/228720@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Aug 28, 2020
1 parent 7f48449 commit ff9cfc7
Show file tree
Hide file tree
Showing 8 changed files with 893 additions and 29 deletions.
12 changes: 12 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
2020-08-27 Chris Dumez <cdumez@apple.com>

AudioParam's minValue / maxValue are ignored
https://bugs.webkit.org/show_bug.cgi?id=215905

Reviewed by Darin Adler.

Import layout test coverage from Blink.

* webaudio/audioparam-nominal-range-expected.txt: Added.
* webaudio/audioparam-nominal-range.html: Added.

2020-08-27 Ryosuke Niwa <rniwa@webkit.org>

Prevent infinite recursion when upgrading custom elements
Expand Down
329 changes: 329 additions & 0 deletions LayoutTests/webaudio/audioparam-nominal-range-expected.txt

Large diffs are not rendered by default.

0 comments on commit ff9cfc7

Please sign in to comment.