Add customElements.getName method by rniwa · Pull Request #13053 · WebKit/WebKit

rniwa · 2023-04-21T22:42:18Z

`e2748d7`

Add customElements.getName method
https://bugs.webkit.org/show_bug.cgi?id=255778

Reviewed by Alexey Shvayka and Chris Dumez.

Implement whatwg/html#9195 with test cases added in
web-platform-tests/wpt#39640

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html:
* Source/WebCore/dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::getName): Added.
* Source/WebCore/dom/CustomElementRegistry.h:
* Source/WebCore/dom/CustomElementRegistry.idl:

Canonical link: https://commits.webkit.org/263281@main

f21fc1a

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	~~🛠 watch~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-21T22:45:06Z

EWS run on previous version of this PR (hash cf869e1)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp

shvaikalesh · 2023-04-21T23:35:20Z

Source/WebCore/dom/CustomElementRegistry.idl

Suggested change

[Custom] DOMString? getName(any constructor);

[Custom] DOMString? getName(Function constructor);

Hm... this results in an error like this:

Could NOT find IDL file for interface "Function"! Could NOT find IDL file for interface "Function"!

webkit-early-warning-system · 2023-04-21T23:53:18Z

EWS run on previous version of this PR (hash e16454a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	✅ 🛠 watch-sim

cdumez

LGTM with nit.

Source/WebCore/dom/CustomElementRegistry.idl

webkit-early-warning-system · 2023-04-22T06:03:10Z

EWS run on previous version of this PR (hash 253cb16)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-22T07:40:59Z

EWS run on previous version of this PR (hash a7e0b6b)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	⏳ 🛠 watch
	✅ 🛠 watch-sim

rniwa · 2023-04-22T07:59:32Z

Source/WebCore/dom/CustomElementRegistry.cpp

Can't use the name "interface" on Windows. It's why WinCairo is failing to build.
This comes up every time I touch this file. It's annoying as hell...

webkit-early-warning-system · 2023-04-22T08:01:14Z

EWS run on current version of this PR (hash f21fc1a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	~~🛠 watch~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=255778 Reviewed by Alexey Shvayka and Chris Dumez. Implement whatwg/html#9195 with test cases added in web-platform-tests/wpt#39640. * LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html: * Source/WebCore/dom/CustomElementRegistry.cpp: (WebCore::CustomElementRegistry::getName): Added. * Source/WebCore/dom/CustomElementRegistry.h: * Source/WebCore/dom/CustomElementRegistry.idl: Canonical link: https://commits.webkit.org/263281@main

webkit-commit-queue · 2023-04-22T19:27:44Z

Committed 263281@main (e2748d7): https://commits.webkit.org/263281@main

Reviewed commits have been landed. Closing PR #13053 and removing active labels.

rniwa requested a review from cdumez as a code owner April 21, 2023 22:42

rniwa self-assigned this Apr 21, 2023

rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 21, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 21, 2023

shvaikalesh reviewed Apr 21, 2023

View reviewed changes

Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp Outdated Show resolved Hide resolved

shvaikalesh approved these changes Apr 21, 2023

View reviewed changes

shvaikalesh reviewed Apr 21, 2023

View reviewed changes

rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 21, 2023

rniwa force-pushed the fix255778 branch from cf869e1 to e16454a Compare April 21, 2023 23:53

cdumez approved these changes Apr 22, 2023

View reviewed changes

Source/WebCore/dom/CustomElementRegistry.idl Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa force-pushed the fix255778 branch from e16454a to 253cb16 Compare April 22, 2023 06:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa force-pushed the fix255778 branch from 253cb16 to a7e0b6b Compare April 22, 2023 07:40

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa commented Apr 22, 2023

View reviewed changes

rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa force-pushed the fix255778 branch from a7e0b6b to f21fc1a Compare April 22, 2023 08:01

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023

rniwa added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 22, 2023

webkit-commit-queue force-pushed the fix255778 branch from f21fc1a to e2748d7 Compare April 22, 2023 19:27

webkit-commit-queue merged commit e2748d7 into WebKit:main Apr 22, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 22, 2023

rniwa deleted the fix255778 branch April 22, 2023 19:28

This was referenced Apr 23, 2023

Add customElements.getName(constructor) whatwg/html#9195

Merged

customElements.getName mozilla/standards-positions#785

Closed

This was referenced Jun 21, 2023

add customelements getname method mdn/browser-compat-data#20186

Merged

add customelements getname method mdn/content#27465

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add customElements.getName method#13053

Add customElements.getName method#13053
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rniwa:fix255778

rniwa commented Apr 21, 2023 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Apr 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

shvaikalesh Apr 21, 2023

Uh oh!

rniwa Apr 22, 2023

Uh oh!

webkit-early-warning-system commented Apr 21, 2023 •

edited

Loading

Uh oh!

cdumez left a comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading

Uh oh!

rniwa Apr 22, 2023

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading

Uh oh!

webkit-commit-queue commented Apr 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	[Custom] DOMString? getName(any constructor);
	[Custom] DOMString? getName(Function constructor);

Conversation

rniwa commented Apr 21, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e2748d7

Uh oh!

webkit-early-warning-system commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shvaikalesh Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

rniwa Apr 22, 2023

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rniwa Apr 22, 2023

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Apr 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rniwa commented Apr 21, 2023 •

edited by webkit-early-warning-system

Loading

`e2748d7`

webkit-early-warning-system commented Apr 21, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 21, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 22, 2023 •

edited

Loading