[GStreamer][WebRTC] Tighten EndPoint pipeline with playback pipeline #13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
the
Platform
Collaborator
|
EWS run on previous version of this PR (hash 1035584)
|
webkit-ews-buildbot
added
the
merging-blocked
calvaris
approved these changes
Apr 28, 2023
Contributor
There was a problem hiding this comment.
Shouldn't you assert if that has a value and then then it?
Member
Author
There was a problem hiding this comment.
can't parse the question :)
Member
Author
There was a problem hiding this comment.
Do you mean
ASSERT(internalSource->m_webrtcSourceClientId)
auto clientId = internalSource->m_webrtcSourceClientId.value();
¿
Contributor
There was a problem hiding this comment.
Sorry, I meant that I think you should assert on the value to have an actual value and then retrieving it. Now you're doing the other way around and it looks weird, but I might be missing something.
Collaborator
|
EWS run on current version of this PR (hash 993b131) |
🛠 🧪 jsc-arm64
https://bugs.webkit.org/show_bug.cgi?id=256041 Reviewed by Xabier Rodriguez-Calvar. The RTP depayloaders and parsers are now wrapped by the RealtimeIncomingSourceGStreamer sub-classes, using parsebin. The relationship between the incoming source appsink and the mediastreamsrc appsrc elements is also stronger, latency is now properly propagated and queries are relayed. This all helps improving lip-sync of incoming WebRTC tracks. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): (WebCore::MediaPlayerPrivateGStreamer::configureDepayloader): Deleted. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: (webkitMediaStreamSrcAddTrack): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::RealtimeIncomingSourceGStreamer): (WebCore::RealtimeIncomingSourceGStreamer::registerClient): (WebCore::RealtimeIncomingSourceGStreamer::unregisterClient): (WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamEvent): (WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamQuery): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h: (WebCore::RealtimeIncomingSourceGStreamer::bin): Canonical link: https://commits.webkit.org/263499@main
webkit-commit-queue
force-pushed
the
eng/256041
branch
from
993b131 to
72fe397
Compare
Collaborator
|
Committed 263499@main (72fe397): https://commits.webkit.org/263499@main Reviewed commits have been landed. Closing PR #13235 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
72fe397
993b131
🧪 wpe-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2