Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BuildStream] Migrate to commit identifier for version keeping #1419

Merged
merged 0 commits into from Jun 14, 2022
Merged

[BuildStream] Migrate to commit identifier for version keeping #1419

merged 0 commits into from Jun 14, 2022

Conversation

philn
Copy link
Member

@philn philn commented Jun 9, 2022 •
edited by webkit-early-warning-system

fd01740

[BuildStream] Migrate to commit identifier for version keeping
https://bugs.webkit.org/show_bug.cgi?id=241469

Patch by Philippe Normand <philn@igalia.com > on 2022-06-14
Reviewed by Adrian Perez de Castro and Jonathan Bedard.

* Tools/buildstream/utils/generate-version:
* Tools/glib/svn-revision: Deleted.

Canonical link: https://commits.webkit.org/251528@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@philn philn requested a review from JonWBedard as a code owner June 9, 2022 16:21
@philn philn self-assigned this Jun 9, 2022
@philn philn added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Jun 9, 2022
@philn philn requested a review from aperezdc June 9, 2022 16:22
JonWBedard
JonWBedard approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@JonWBedard JonWBedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, although git-webkit find HEAD -q might be easier if all you're doing with the webkit-revision script is invoking it in generate-version

@philn
Copy link
Member Author

philn commented Jun 11, 2022

Change looks good, although git-webkit find HEAD -q might be easier if all you're doing with the webkit-revision script is invoking it in generate-version

Hm yes, that's a good point. I'll give it a try. Thanks for the reviews!

@philn
Copy link
Member Author

philn commented Jun 11, 2022

The EWS bots seem a bit fluked. Failing to apply/rebase the patch, failing on unrelated files.

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit fd01740 into WebKit:main Jun 14, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295523 (251528@main): https://commits.webkit.org/251528@main

Reviewed commits have been landed. Closing PR #1419 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2022
@philn philn deleted the eng/241469 branch June 14, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@JonWBedard JonWBedard JonWBedard approved these changes

Assignees

@philn philn

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@philn @webkit-early-warning-system @aperezdc @JonWBedard