Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION: fast/history/visited-link-caret-color.html is a consistent image failure #16059

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Jul 25, 2023

eb3e815

REGRESSION: fast/history/visited-link-caret-color.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=259469
rdar://111077813

Reviewed by Megan Gardner and Aditya Keerthi.

When the caret doesn't need to use the system accent color, it should just get the color the normal
way, which already both accounts for the visited-ness and any color filter.

* LayoutTests/fast/history/visited-link-caret-color-expected.html:
* LayoutTests/fast/history/visited-link-caret-color.html:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):

Canonical link: https://commits.webkit.org/266295@main

a2cacd8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@rr-codes rr-codes requested a review from rniwa as a code owner July 25, 2023 04:23
@rr-codes rr-codes self-assigned this Jul 25, 2023
@rr-codes rr-codes added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Jul 25, 2023
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2023
…t image failure

https://bugs.webkit.org/show_bug.cgi?id=259469
rdar://111077813

Reviewed by Megan Gardner and Aditya Keerthi.

When the caret doesn't need to use the system accent color, it should just get the color the normal
way, which already both accounts for the visited-ness and any color filter.

* LayoutTests/fast/history/visited-link-caret-color-expected.html:
* LayoutTests/fast/history/visited-link-caret-color.html:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):

Canonical link: https://commits.webkit.org/266295@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266295@main (eb3e815): https://commits.webkit.org/266295@main

Reviewed commits have been landed. Closing PR #16059 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit eb3e815 into WebKit:main Jul 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants