Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteRenderingBackend::prepareBuffersForDisplay should move its result into the completion handler #1932

Merged
merged 1 commit into from Jun 30, 2022
Merged

RemoteRenderingBackend::prepareBuffersForDisplay should move its result into the completion handler #1932

merged 1 commit into from Jun 30, 2022

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Jun 30, 2022 •
edited by webkit-commit-queue

29e7147

RemoteRenderingBackend::prepareBuffersForDisplay should move its result into the completion handler
https://bugs.webkit.org/show_bug.cgi?id=242158

Reviewed by Tim Horton.

We currently copy the contents of the PrepareBackingStoreBuffersOutputData
vector, which means retaining and releasing a Mach send right unnecessarily.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::prepareBuffersForDisplay):

Canonical link: https://commits.webkit.org/251976@main

@heycam heycam self-assigned this Jun 30, 2022
@heycam heycam added WebKit Nightly Build WebKit Process Model Bugs related to WebKit's multi-process architecture labels Jun 30, 2022
@heycam heycam force-pushed the prepare-buffers-send-right branch from 074a6a2 to 2ac35b0 Compare June 30, 2022 02:24
@heycam heycam added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2022
@heycam
RemoteRenderingBackend::prepareBuffersForDisplay should move its resu…
29e7147 
…lt into the completion handler

https://bugs.webkit.org/show_bug.cgi?id=242158

Reviewed by Tim Horton.

We currently copy the contents of the PrepareBackingStoreBuffersOutputData
vector, which means retaining and releasing a Mach send right unnecessarily.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::prepareBuffersForDisplay):

Canonical link: https://commits.webkit.org/251976@main
@webkit-commit-queue
Copy link
Collaborator

Committed 251976@main (29e7147): https://commits.webkit.org/251976@main

Reviewed commits have been landed. Closing PR #1932 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 29e7147 into WebKit:main Jun 30, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2022
yury-s pushed a commit to yury-s/WebKit that referenced this pull request Nov 2, 2023
@yury-s
chore(webkit): bootstrap build WebKit#1932
a070ae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

Assignees

@heycam heycam

Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
Milestone
No milestone
4 participants
@heycam @webkit-commit-queue @hortont424 @webkit-early-warning-system