Add CustomStateSet and :state() selector #20012

keithamus · 2023-11-05T16:31:30Z

`59cb7cb`

Add CustomStateSet and :state() selector
https://bugs.webkit.org/show_bug.cgi?id=215911

Reviewed by Tim Nguyen.

This adds the CustomStateSet idl definitions, and the `states` getter in
the ElementInternals IDL. The gatter laziliy initialises a
CustomStateSet object in ElementRareData which behaves like a
setlike<DOMString>.

This also adds the `:state()` pseudo selector, which can take an ident
and matches when the ident matches one of the given states in the
CustomStateSet for the element.

Any states set by CustomStateSet need to invalidate styles for the
element, so the `:state()` pseudo can match.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/state-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/state-in-has.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/ElementInternals-states-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/ElementInternals-states.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/custom-state-set-strong-ref.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/idlharness.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector-shadow-dom.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector-shadow-dom.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector.tentative-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::isOnlyPseudoClassFunction):
(WebCore::CSSSelectorParser::consumePseudo):
* Source/WebCore/css/parser/CSSSelectorParserContext.cpp:
(WebCore::CSSSelectorParserContext::CSSSelectorParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSSelectorParserContext.h:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
* Source/WebCore/dom/CustomStateSet.cpp: Added.
(WebCore::CustomStateSet::addToSetLike):
(WebCore::CustomStateSet::removeFromSetLike):
(WebCore::CustomStateSet::clearFromSetLike):
(WebCore::CustomStateSet::has):
* Source/WebCore/dom/CustomStateSet.h: Added.
* Source/WebCore/dom/CustomStateSet.idl: Added.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasCustomState const):
(WebCore::Element::ensureCustomStateSet):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ElementInternals.cpp:
(WebCore::ElementInternals::states):
* Source/WebCore/dom/ElementInternals.h:
* Source/WebCore/dom/ElementInternals.idl:
* Source/WebCore/dom/ElementRareData.cpp:
* Source/WebCore/dom/ElementRareData.h:
(WebCore::ElementRareData::customStateSet):
(WebCore::ElementRareData::setCustomStateSet):
(WebCore::ElementRareData::useTypes const):
* Source/WebCore/dom/NodeRareData.h:

Canonical link: https://commits.webkit.org/271600@main

e495b9d

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
~~🛠 🧪 jsc~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
~~🛠 🧪 jsc-arm64~~	~~🛠 tv~~	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	~~🛠 watch-sim~~

webkit-early-warning-system · 2023-11-05T16:31:40Z

EWS run on previous version of this PR (hash 6f53614)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		~~🛠 jsc-mips~~
	⏳ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-11-05T16:34:18Z

EWS run on previous version of this PR (hash 6c736b2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

nt1m

You'll need to add a special case at: https://searchfox.org/wubkat/rev/023c54054092dc68c5df3b230ed3137cbd753b16/Source/WebCore/css/parser/CSSSelectorParser.cpp#743-763

Otherwise, :state with no argument won't be rejected.

Source/WebCore/css/CSSSelector.cpp

Source/WebCore/dom/CustomStateSet.h

Source/WebCore/dom/Element.cpp

Source/WebCore/dom/CustomStateSet.cpp

rniwa · 2023-11-05T19:28:59Z

https://bugs.webkit.org/show_bug.cgi?id=215911

There should be the but title right above it.

This adds the CustomStateSet idl definitions, and the states getter in the ElementInternals IDL. The gatter laziliy initialises a CustomStateSet object in ElementRareData which behaves like a setlike.

Please insert a line break after 100 characters or so.

Source/WebCore/css/SelectorChecker.cpp

Source/WebCore/cssjit/SelectorCompiler.cpp

Source/WebCore/dom/CustomStateSet.idl

Source/WebCore/dom/Element.cpp

webkit-early-warning-system · 2023-11-05T23:51:57Z

EWS run on previous version of this PR (hash 7465195)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/dom/CustomStateSet.cpp

LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html

rniwa · 2023-11-06T06:12:10Z

We should add a test for invalidating :host:state(foo).

webkit-early-warning-system · 2023-11-11T14:00:23Z

EWS run on previous version of this PR (hash c0b9fb8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-11T16:27:35Z

EWS run on previous version of this PR (hash 59572bc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

nt1m · 2023-11-11T17:22:47Z

...ests/imported/w3c/web-platform-tests/custom-elements/state.tentative/state-pseudo-class.html

Can we do a WPT resync of custom-elements/ and custom-state-pseudo-class separately ? I think it'll make it easier for you to export, and it's easier to review generally since it's clear which ones are new tests.

Source/WebCore/cssjit/SelectorCompiler.cpp

Source/WebCore/css/CSSSelector.cpp

webkit-early-warning-system · 2023-11-11T20:31:30Z

EWS run on previous version of this PR (hash b91a03b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-12T10:03:12Z

EWS run on previous version of this PR (hash b7014c8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/cssjit/SelectorCompiler.cpp

webkit-early-warning-system · 2023-11-12T20:41:36Z

EWS run on previous version of this PR (hash 150ba3f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/css/parser/CSSSelectorParserContext.h

webkit-early-warning-system · 2023-12-04T18:06:12Z

EWS run on previous version of this PR (hash 5ca372f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

...ests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class.html

Source/WebCore/dom/CustomStateSet.cpp

Source/WebCore/dom/CustomStateSet.idl

Source/WebCore/dom/CustomStateSet.cpp

Source/WebCore/dom/Element.cpp

Source/WebCore/dom/ElementInternals.cpp

Source/WebCore/dom/Element.cpp

webkit-early-warning-system · 2023-12-05T00:11:16Z

EWS run on previous version of this PR (hash 05af113)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-05T08:15:15Z

EWS run on previous version of this PR (hash 4c409a8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
❌ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

Source/WebCore/dom/CustomStateSet.idl

webkit-early-warning-system · 2023-12-06T09:56:38Z

EWS run on current version of this PR (hash e495b9d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
~~🛠 🧪 jsc~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
~~🛠 🧪 jsc-arm64~~	~~🛠 tv~~	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	~~🛠 watch-sim~~

https://bugs.webkit.org/show_bug.cgi?id=215911 Reviewed by Tim Nguyen. This adds the CustomStateSet idl definitions, and the `states` getter in the ElementInternals IDL. The gatter laziliy initialises a CustomStateSet object in ElementRareData which behaves like a setlike<DOMString>. This also adds the `:state()` pseudo selector, which can take an ident and matches when the ident matches one of the given states in the CustomStateSet for the element. Any states set by CustomStateSet need to invalidate styles for the element, so the `:state()` pseudo can match. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/state-in-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/state-in-has.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/ElementInternals-states-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/ElementInternals-states.html: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class.html: * LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/custom-state-set-strong-ref.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/idlharness.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector-shadow-dom.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector-shadow-dom.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/custom-state-pseudo-class/state-css-selector.tentative-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * Source/WebCore/css/CSSSelector.h: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::isOnlyPseudoClassFunction): (WebCore::CSSSelectorParser::consumePseudo): * Source/WebCore/css/parser/CSSSelectorParserContext.cpp: (WebCore::CSSSelectorParserContext::CSSSelectorParserContext): (WebCore::add): * Source/WebCore/css/parser/CSSSelectorParserContext.h: * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::addPseudoClassType): * Source/WebCore/dom/CustomStateSet.cpp: Added. (WebCore::CustomStateSet::addToSetLike): (WebCore::CustomStateSet::removeFromSetLike): (WebCore::CustomStateSet::clearFromSetLike): (WebCore::CustomStateSet::has): * Source/WebCore/dom/CustomStateSet.h: Added. * Source/WebCore/dom/CustomStateSet.idl: Added. * Source/WebCore/dom/Element.cpp: (WebCore::Element::hasCustomState const): (WebCore::Element::ensureCustomStateSet): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/ElementInternals.cpp: (WebCore::ElementInternals::states): * Source/WebCore/dom/ElementInternals.h: * Source/WebCore/dom/ElementInternals.idl: * Source/WebCore/dom/ElementRareData.cpp: * Source/WebCore/dom/ElementRareData.h: (WebCore::ElementRareData::customStateSet): (WebCore::ElementRareData::setCustomStateSet): (WebCore::ElementRareData::useTypes const): * Source/WebCore/dom/NodeRareData.h: Canonical link: https://commits.webkit.org/271600@main

webkit-commit-queue · 2023-12-06T11:06:40Z

Committed 271600@main (59cb7cb): https://commits.webkit.org/271600@main

Reviewed commits have been landed. Closing PR #20012 and removing active labels.

keithamus force-pushed the custom-state-set branch from 6f53614 to 6c736b2 Compare November 5, 2023 16:34

nt1m reviewed Nov 5, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 5, 2023

rniwa reviewed Nov 5, 2023

View reviewed changes

Source/WebCore/css/SelectorChecker.cpp Outdated Show resolved Hide resolved

rniwa reviewed Nov 5, 2023

View reviewed changes

Source/WebCore/cssjit/SelectorCompiler.cpp Outdated Show resolved Hide resolved

rniwa reviewed Nov 5, 2023

View reviewed changes

Source/WebCore/dom/CustomStateSet.idl Outdated Show resolved Hide resolved

rniwa reviewed Nov 5, 2023

View reviewed changes

Source/WebCore/dom/Element.cpp Outdated Show resolved Hide resolved

keithamus force-pushed the custom-state-set branch from 6c736b2 to 7465195 Compare November 5, 2023 23:51

nt1m reviewed Nov 6, 2023

View reviewed changes

Source/WebCore/dom/CustomStateSet.cpp Outdated Show resolved Hide resolved

LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html Outdated Show resolved Hide resolved

keithamus force-pushed the custom-state-set branch from 7465195 to c0b9fb8 Compare November 11, 2023 14:00

keithamus force-pushed the custom-state-set branch from c0b9fb8 to 59572bc Compare November 11, 2023 16:27

nt1m reviewed Nov 11, 2023

View reviewed changes

keithamus force-pushed the custom-state-set branch from 59572bc to b91a03b Compare November 11, 2023 20:31

Ahmad-S792 assigned keithamus Nov 12, 2023

Ahmad-S792 added DOM For bugs specific to XML/HTML DOM elements (including parsing). and removed merging-blocked Applied to prevent a change from being merged labels Nov 12, 2023

keithamus force-pushed the custom-state-set branch from b91a03b to b7014c8 Compare November 12, 2023 10:03

nt1m reviewed Nov 12, 2023

View reviewed changes

Source/WebCore/cssjit/SelectorCompiler.cpp Outdated Show resolved Hide resolved

keithamus force-pushed the custom-state-set branch from b7014c8 to 150ba3f Compare November 12, 2023 20:41

keithamus force-pushed the custom-state-set branch from 150ba3f to ad2d21b Compare November 12, 2023 22:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 4, 2023

nt1m reviewed Dec 4, 2023

View reviewed changes

Source/WebCore/css/parser/CSSSelectorParserContext.h Outdated Show resolved Hide resolved

keithamus force-pushed the custom-state-set branch from 19ba7cc to 5ca372f Compare December 4, 2023 17:59

nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 4, 2023

nt1m reviewed Dec 4, 2023

View reviewed changes

...ests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class.html Outdated Show resolved Hide resolved

cdumez reviewed Dec 4, 2023

View reviewed changes

keithamus force-pushed the custom-state-set branch from 5ca372f to 05af113 Compare December 5, 2023 00:11

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 5, 2023

keithamus force-pushed the custom-state-set branch from 05af113 to 4c409a8 Compare December 5, 2023 08:15

keithamus removed the merging-blocked Applied to prevent a change from being merged label Dec 5, 2023

keithamus requested review from cdumez and nt1m December 5, 2023 10:33

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 5, 2023

nt1m approved these changes Dec 5, 2023

View reviewed changes

Source/WebCore/dom/CustomStateSet.idl Outdated Show resolved Hide resolved

keithamus force-pushed the custom-state-set branch from 4c409a8 to e495b9d Compare December 6, 2023 09:03

keithamus added request-merge-queue Request a pull request to be added to merge-queue once ready and removed merging-blocked Applied to prevent a change from being merged labels Dec 6, 2023

Ahmad-S792 added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Dec 6, 2023

webkit-commit-queue force-pushed the custom-state-set branch from e495b9d to 59cb7cb Compare December 6, 2023 11:05

webkit-commit-queue merged commit 59cb7cb into WebKit:main Dec 6, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 6, 2023

keithamus deleted the custom-state-set branch December 6, 2023 11:09

keithamus mentioned this pull request Dec 6, 2023

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=264226 web-platform-tests/wpt#43541

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CustomStateSet and :state() selector #20012

Add CustomStateSet and :state() selector #20012

keithamus commented Nov 5, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 5, 2023 •

edited

webkit-early-warning-system commented Nov 5, 2023 •

edited

nt1m left a comment

rniwa commented Nov 5, 2023

webkit-early-warning-system commented Nov 5, 2023 •

edited

rniwa commented Nov 6, 2023

webkit-early-warning-system commented Nov 11, 2023 •

edited

webkit-early-warning-system commented Nov 11, 2023 •

edited

nt1m Nov 11, 2023

webkit-early-warning-system commented Nov 11, 2023 •

edited

webkit-early-warning-system commented Nov 12, 2023 •

edited

webkit-early-warning-system commented Nov 12, 2023 •

edited

webkit-early-warning-system commented Dec 4, 2023 •

edited

webkit-early-warning-system commented Dec 5, 2023 •

edited

webkit-early-warning-system commented Dec 5, 2023 •

edited

webkit-early-warning-system commented Dec 6, 2023 •

edited

webkit-commit-queue commented Dec 6, 2023

Add CustomStateSet and :state() selector #20012

Add CustomStateSet and :state() selector #20012

Conversation

keithamus commented Nov 5, 2023 • edited by webkit-early-warning-system

59cb7cb

webkit-early-warning-system commented Nov 5, 2023 • edited

webkit-early-warning-system commented Nov 5, 2023 • edited

nt1m left a comment

Choose a reason for hiding this comment

rniwa commented Nov 5, 2023

webkit-early-warning-system commented Nov 5, 2023 • edited

rniwa commented Nov 6, 2023

webkit-early-warning-system commented Nov 11, 2023 • edited

webkit-early-warning-system commented Nov 11, 2023 • edited

nt1m Nov 11, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Nov 11, 2023 • edited

webkit-early-warning-system commented Nov 12, 2023 • edited

webkit-early-warning-system commented Nov 12, 2023 • edited

webkit-early-warning-system commented Dec 4, 2023 • edited

webkit-early-warning-system commented Dec 5, 2023 • edited

webkit-early-warning-system commented Dec 5, 2023 • edited

webkit-early-warning-system commented Dec 6, 2023 • edited

webkit-commit-queue commented Dec 6, 2023

keithamus commented Nov 5, 2023 •

edited by webkit-early-warning-system

`59cb7cb`

webkit-early-warning-system commented Nov 5, 2023 •

edited

webkit-early-warning-system commented Nov 5, 2023 •

edited

webkit-early-warning-system commented Nov 5, 2023 •

edited

webkit-early-warning-system commented Nov 11, 2023 •

edited

webkit-early-warning-system commented Nov 11, 2023 •

edited

webkit-early-warning-system commented Nov 11, 2023 •

edited

webkit-early-warning-system commented Nov 12, 2023 •

edited

webkit-early-warning-system commented Nov 12, 2023 •

edited

webkit-early-warning-system commented Dec 4, 2023 •

edited

webkit-early-warning-system commented Dec 5, 2023 •

edited

webkit-early-warning-system commented Dec 5, 2023 •

edited

webkit-early-warning-system commented Dec 6, 2023 •

edited