markAllBackingStoreVolatileFromTimer can stop the volatility timer too soon and not mark all surfaces as volatile. #20014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash ee92e02)
|
mattwoodrow
added
the
Layout and Rendering
smfr
reviewed
Nov 6, 2023
| LOG_WITH_STREAM(RemoteLayerBuffers, stream << "RemoteLayerWithRemoteRenderingBackingStoreCollection::markBackingStoreVolatileAfterReachabilityChange - succeeded " << succeeded); | ||
| if (!succeeded && weakThis) | ||
| weakThis->scheduleVolatilityTimer(); |
There was a problem hiding this comment.
Is there some risk that we never succeed and keep scheduling this timer forever?
There was a problem hiding this comment.
I think that risk is existing, the volatility timer is repeating, and it's only the successful marking of all surfaces that explicitly stops it.
|
Commit message contains (OOPS!) and no reviewer found, blocking PR #20014 |
webkit-commit-queue
added
merging-blocked
smfr
approved these changes
Nov 9, 2023
mattwoodrow
added
merge-queue
…o soon and not mark all surfaces as volatile. https://bugs.webkit.org/show_bug.cgi?id=264229 <rdar://116711724> Reviewed by Simon Fraser. RemoteLayerWithRemoteRenderingBackingStoreCollection::markAllBackingStoreVolatileFromTimer stops the volatility timer if the operation is successful, since there should be no further backing stores to mark volatile. This is an async operation though, and it's possible for markBackingStoreVolatileAfterReachabilityChange to have been called in the interim and there are now new backing stores that aren't yet volatile. This change ensures that we reschedule the volatility timer if any markBackingStoreVolatileAfterReachabilityChange don't succesfully mark the relevant surfaces as volatile. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::markBackingStoreVolatileAfterReachabilityChange): Canonical link: https://commits.webkit.org/270486@main
webkit-commit-queue
force-pushed
the
eng/volatility-timer-race
branch
from
ee92e02
to
a6666b9
Compare
|
Committed 270486@main (a6666b9): https://commits.webkit.org/270486@main Reviewed commits have been landed. Closing PR #20014 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a6666b9
ee92e02