Skip to content

expose <address> and <fieldset> as aria group#20751

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
keithamus:expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621
Nov 21, 2023
Merged

expose <address> and <fieldset> as aria group#20751
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
keithamus:expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621

Conversation

@keithamus
Copy link
Copy Markdown
Member

@keithamus keithamus commented Nov 20, 2023 •
edited by webkit-early-warning-system
Loading

51444d3

expose `<address>` and `<fieldset>` as aria group
https://bugs.webkit.org/show_bug.cgi?id=255621

Reviewed by Tyler Wilcock.

Address and Fieldset were incorrectly marked as "Group" which is a
generic AccessibilityRole that does not get exposed as the ARIA "Group"
role. The correct role to expose as "Group" is "ApplicationGroup".

This changes both address tags and fieldset tags to be
"ApplicationGroup".

Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com>
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>

* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

Canonical link: https://commits.webkit.org/271021@main

e6392eb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Nov 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a57a0d5)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@keithamus keithamus marked this pull request as ready for review November 20, 2023 18:38
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 20, 2023
@keithamus keithamus force-pushed the expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621 branch from a57a0d5 to 550270d Compare November 20, 2023 21:10
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Nov 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 550270d)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added Accessibility For bugs related to accessibility. and removed merging-blocked Applied to prevent a change from being merged labels Nov 20, 2023
@twilco
Copy link
Copy Markdown
Contributor

twilco commented Nov 21, 2023

Thank you Keith, Kate, and Lindsey! I think you'll also need to update the iOS-specific results, located at LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt. Diff should be accessible from the ios-wk2-wpt bot run, then "view layout test results" in the re-run layout tests section.

@keithamus keithamus force-pushed the expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621 branch from 550270d to e6392eb Compare November 21, 2023 09:07
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Nov 21, 2023 •
edited
Loading

EWS run on current version of this PR (hash e6392eb)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@keithamus
Copy link
Copy Markdown
Member Author

keithamus commented Nov 21, 2023

The "view layout test results" link lead to a 404 on s3, but I manually edited the file to match.

@twilco twilco added the merge-queue Applied to send a pull request to merge-queue label Nov 21, 2023
@keithamus @twilco
expose <address> and <fieldset> as aria group
51444d3 
https://bugs.webkit.org/show_bug.cgi?id=255621

Reviewed by Tyler Wilcock.

Address and Fieldset were incorrectly marked as "Group" which is a
generic AccessibilityRole that does not get exposed as the ARIA "Group"
role. The correct role to expose as "Group" is "ApplicationGroup".

This changes both address tags and fieldset tags to be
"ApplicationGroup".

Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com>
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>

* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

Canonical link: https://commits.webkit.org/271021@main
@webkit-commit-queue webkit-commit-queue force-pushed the expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621 branch from e6392eb to 51444d3 Compare November 21, 2023 18:03
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Nov 21, 2023

Committed 271021@main (51444d3): https://commits.webkit.org/271021@main

Reviewed commits have been landed. Closing PR #20751 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 51444d3 into WebKit:main Nov 21, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 21, 2023
@keithamus keithamus deleted the expose-address-and-fieldset-as-aria-group-https-bugs-webkit-org-show-bug-cgi-id-255621 branch November 21, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twilco twilco twilco approved these changes

Assignees

@keithamus keithamus

Labels

Accessibility For bugs related to accessibility.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@keithamus @webkit-early-warning-system @twilco @webkit-commit-queue @Ahmad-S792 @webkit-ews-buildbot