Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resync CSS selector parsing tests #21264

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Dec 4, 2023

e694f63

resync CSS selector parsing tests
https://bugs.webkit.org/show_bug.cgi?id=265785

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@5ddf095

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log:

Canonical link: https://commits.webkit.org/271484@main

dea0fda

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rebaseline the tests too.

@keithamus
Copy link
Member Author

Yeah I raised as draft to get CI to build so I can rebaseline, as my CPU is currently busy recompiling Chrome πŸ˜…

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 4, 2023
@keithamus keithamus force-pushed the resync-css-selector-parsing-tests-https-bugs-webkit-org-show-bug-cgi-id-265785 branch from 8cb36b4 to 921497a Compare December 4, 2023 12:06
@keithamus keithamus force-pushed the resync-css-selector-parsing-tests-https-bugs-webkit-org-show-bug-cgi-id-265785 branch from 921497a to dea0fda Compare December 4, 2023 13:07
@keithamus keithamus added request-merge-queue Request a pull request to be added to merge-queue once ready and removed merging-blocked Applied to prevent a change from being merged labels Dec 4, 2023
@Ahmad-S792 Ahmad-S792 added the CSS Cascading Style Sheets implementation label Dec 4, 2023
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review December 4, 2023 14:22
@Ahmad-S792
Copy link
Contributor

@keithamus - once ios-wk2-wpt finished, I will add 'merge-queue' or if someone else beat me to it.

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Dec 4, 2023
@Ahmad-S792 Ahmad-S792 added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=265785

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@5ddf095

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt: Rebaselined.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log:

Canonical link: https://commits.webkit.org/271484@main
@webkit-commit-queue webkit-commit-queue force-pushed the resync-css-selector-parsing-tests-https-bugs-webkit-org-show-bug-cgi-id-265785 branch from dea0fda to e694f63 Compare December 4, 2023 17:07
@webkit-commit-queue webkit-commit-queue merged commit e694f63 into WebKit:main Dec 4, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 271484@main (e694f63): https://commits.webkit.org/271484@main

Reviewed commits have been landed. Closing PR #21264 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 4, 2023
@keithamus keithamus deleted the resync-css-selector-parsing-tests-https-bugs-webkit-org-show-bug-cgi-id-265785 branch December 4, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
6 participants