New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename pseudoClasss to pseudoClasses #22232
rename pseudoClasss to pseudoClasses #22232
Conversation
39a82f6
to
2379089
Compare
|
EWS run on previous version of this PR (hash 2379089)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit message you probably want to refer to 272468@main for consistency.
Non-reviewer looks good otherwise and thanks for catching this!
2379089
to
1ec74e9
Compare
|
EWS run on current version of this PR (hash 1ec74e9)
|
https://bugs.webkit.org/show_bug.cgi?id=266841 Reviewed by Tim Nguyen. In https://commits.webkit.org/272468@main `pseudoClassType` was renamed to `pseudoClass` but this variable got caught in the find and replace and became `pseudoClasss` instead of `pseudoClasses`. * Source/WebCore/style/PseudoClassChangeInvalidation.cpp: (WebCore::Style::PseudoClassChangeInvalidation::computeInvalidation): * Source/WebCore/style/RuleFeature.cpp: (WebCore::Style::RuleFeatureSet::collectFeatures): (WebCore::Style::RuleFeatureSet::add): (WebCore::Style::RuleFeatureSet::clear): * Source/WebCore/style/RuleFeature.h: Canonical link: https://commits.webkit.org/272490@main
1ec74e9
to
96d9229
Compare
|
Committed 272490@main (96d9229): https://commits.webkit.org/272490@main Reviewed commits have been landed. Closing PR #22232 and removing active labels. |
96d9229
1ec74e9