Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pseudoClasss to pseudoClasses #22232

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Dec 24, 2023

96d9229

rename pseudoClasss to pseudoClasses
https://bugs.webkit.org/show_bug.cgi?id=266841

Reviewed by Tim Nguyen.

In https://commits.webkit.org/272468@main `pseudoClassType` was
renamed to `pseudoClass` but this variable got caught in the find and
replace and became `pseudoClasss` instead of `pseudoClasses`.

* Source/WebCore/style/PseudoClassChangeInvalidation.cpp:
(WebCore::Style::PseudoClassChangeInvalidation::computeInvalidation):
* Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
* Source/WebCore/style/RuleFeature.h:

Canonical link: https://commits.webkit.org/272490@main

1ec74e9

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@keithamus keithamus force-pushed the rename-pseudoclasss-to-pseudoclasses-https-bugs-webkit-org-show-bug-cgi-id-266841 branch from 39a82f6 to 2379089 Compare December 24, 2023 10:21
@keithamus keithamus changed the title Rename pseudoclasss to pseudoclasses https bugs webkit org show bug cgi id 266841 Rename pseudoclasss to pseudoclasses Dec 24, 2023
Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message you probably want to refer to 272468@main for consistency.

Non-reviewer looks good otherwise and thanks for catching this!

@keithamus keithamus force-pushed the rename-pseudoclasss-to-pseudoclasses-https-bugs-webkit-org-show-bug-cgi-id-266841 branch from 2379089 to 1ec74e9 Compare December 24, 2023 10:35
@keithamus keithamus added the request-merge-queue Request a pull request to be added to merge-queue once ready label Dec 24, 2023
@Ahmad-S792 Ahmad-S792 added the CSS Cascading Style Sheets implementation label Dec 24, 2023
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=266841

Reviewed by Tim Nguyen.

In https://commits.webkit.org/272468@main `pseudoClassType` was
renamed to `pseudoClass` but this variable got caught in the find and
replace and became `pseudoClasss` instead of `pseudoClasses`.

* Source/WebCore/style/PseudoClassChangeInvalidation.cpp:
(WebCore::Style::PseudoClassChangeInvalidation::computeInvalidation):
* Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
* Source/WebCore/style/RuleFeature.h:

Canonical link: https://commits.webkit.org/272490@main
@webkit-commit-queue webkit-commit-queue changed the title Rename pseudoclasss to pseudoclasses rename pseudoClasss to pseudoClasses Dec 24, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the rename-pseudoclasss-to-pseudoclasses-https-bugs-webkit-org-show-bug-cgi-id-266841 branch from 1ec74e9 to 96d9229 Compare December 24, 2023 17:18
@webkit-commit-queue
Copy link
Collaborator

Committed 272490@main (96d9229): https://commits.webkit.org/272490@main

Reviewed commits have been landed. Closing PR #22232 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 96d9229 into WebKit:main Dec 24, 2023
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing request-merge-queue Request a pull request to be added to merge-queue once ready labels Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
6 participants