[iOS] Stop using AVSystemController and AVAudioSession SPIs when media capability grants are enabled#22293
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 65bfe58) Details |
Contributor
Author
|
Test failure in tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html is unrelated |
…a capability grants are enabled https://bugs.webkit.org/show_bug.cgi?id=266975 rdar://115750175 Reviewed by Per Arne Vollan. When media capability grants are enabled, setting the AVSystemController_PIDToInheritApplicationStateFrom attribute on AVSystemController and calling -[AVAudioSession setAuditTokensForProcessAssertion:error:] are no longer necessary. Plumbed the MediaCapabilityGrantsEnabled web preference to the GPU process and avoided calling these SPIs when the preference is activated. Added a WKPreferences SPI to deactivate the preference for use by clients that are not yet ready to adopt media capability grants. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::mediaCapabilityGrantsEnabled): (WebCore::PlatformMediaSessionManager::setMediaCapabilityGrantsEnabled): * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: * Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm: (MediaSessionHelperIOS::providePresentingApplicationPID): * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::updateGPUProcessPreferences): * Source/WebKit/GPUProcess/GPUProcessPreferences.cpp: (WebKit::GPUProcessPreferences::copyEnabledWebPreferences): * Source/WebKit/GPUProcess/GPUProcessPreferences.h: * Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp: (WebKit::RemoteAudioSessionProxyManager::updatePresentingProcesses): * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _mediaCapabilityGrantsEnabled]): (-[WKPreferences _setMediaCapabilityGrantsEnabled:]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: Canonical link: https://commits.webkit.org/272675@main
65bfe58 to
f0f4cef
Compare
Collaborator
|
Committed 272675@main (f0f4cef): https://commits.webkit.org/272675@main Reviewed commits have been landed. Closing PR #22293 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f0f4cef
65bfe58