Skip to content

Synchronize FileAPI WPT#28845

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Synchronize-FileAPI-WPT
May 22, 2024
Merged

Synchronize FileAPI WPT#28845
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Synchronize-FileAPI-WPT

Conversation

@annevk
Copy link
Copy Markdown
Contributor

@annevk annevk commented May 21, 2024

0b25769

Synchronize FileAPI WPT
https://bugs.webkit.org/show_bug.cgi?id=274457

Reviewed by Tim Nguyen.

Quite a few caveats unfortunately:

- Ignore a test change with Float16Array for now as it would reduce coverage.
- BlobURL/cross-partition.tentative.https.html is not imported for now.
- blob/Blob-methods-from-detached-frame.html is removed as we exported it as
  Blob-methods-from-detached-frame.html and imported that one at a later point.
  So in effect this deduplicates it.
- Many -expected.txt files are removed because --clean-dest-dir was not used
  during prior imports.
- A change to FileAPI/url/multi-global-origin-serialization.sub.html is ignored
  for now.

Latest upstream commit for this directory:
web-platform-tests/wpt@5aa50dd

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/META.yml:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-overflow-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-byob-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-sync-xhr-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.js:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/File-constructor-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-utf-8-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/fileReader-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/Determining-Encoding-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-event-handler-attributes-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_error-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsArrayBuffer-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsBinaryString-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsText-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readystate-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_result-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/sandboxed-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-format.any.js:
(test.t.t.add_cleanup):
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any.js:
(async garbageCollect.else.gcRec): Deleted.
(async garbageCollect): Deleted.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/w3c-import.log:
* LayoutTests/tests-options.json:

Canonical link: https://commits.webkit.org/279121@main

7e0ad57

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
❌ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@annevk annevk self-assigned this May 21, 2024
@annevk annevk added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 21, 2024
@annevk annevk requested a review from youennf May 21, 2024 09:06
Copy link
Copy Markdown
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include upstream commit

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 21, 2024
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label May 22, 2024
@annevk annevk force-pushed the eng/Synchronize-FileAPI-WPT branch from fdfaa26 to 7e0ad57 Compare May 22, 2024 07:08
@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label May 22, 2024
@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels May 22, 2024
@annevk annevk added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels May 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=274457

Reviewed by Tim Nguyen.

Quite a few caveats unfortunately:

- Ignore a test change with Float16Array for now as it would reduce coverage.
- BlobURL/cross-partition.tentative.https.html is not imported for now.
- blob/Blob-methods-from-detached-frame.html is removed as we exported it as
  Blob-methods-from-detached-frame.html and imported that one at a later point.
  So in effect this deduplicates it.
- Many -expected.txt files are removed because --clean-dest-dir was not used
  during prior imports.
- A change to FileAPI/url/multi-global-origin-serialization.sub.html is ignored
  for now.

Latest upstream commit for this directory:
web-platform-tests/wpt@5aa50dd

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/META.yml:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-overflow-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-byob-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-sync-xhr-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.js:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/File-constructor-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-utf-8-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/fileReader-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/Determining-Encoding-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-event-handler-attributes-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_error-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsArrayBuffer-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsBinaryString-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsText-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readystate-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_result-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/sandboxed-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-format.any.js:
(test.t.t.add_cleanup):
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any.js:
(async garbageCollect.else.gcRec): Deleted.
(async garbageCollect): Deleted.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/w3c-import.log:
* LayoutTests/tests-options.json:

Canonical link: https://commits.webkit.org/279121@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Synchronize-FileAPI-WPT branch from 7e0ad57 to 0b25769 Compare May 22, 2024 12:50
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 279121@main (0b25769): https://commits.webkit.org/279121@main

Reviewed commits have been landed. Closing PR #28845 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0b25769 into WebKit:main May 22, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 22, 2024
@annevk annevk deleted the eng/Synchronize-FileAPI-WPT branch May 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants