Media element never populates its UA shadow if it was initially created in a document without browsing context #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
reviewed
Aug 2, 2022
| @@ -1153,6 +1150,9 @@ class HTMLMediaElement | |||
| bool m_shouldVideoPlaybackRequireUserGesture : 1; | |||
| bool m_volumeLocked : 1; | |||
|
|
|||
| enum class ControlsState { None, Initializing, Ready }; | |||
webkit-early-warning-system
added
the
merging-blocked
dcrousso
removed
the
merging-blocked
…ed in a document without browsing context https://bugs.webkit.org/show_bug.cgi?id=222657 <rdar://problem/75266631> Reviewed by Eric Carlson. Previously, `HTMLMediaElement` relied on `didAddUserAgentShadowRoot` to call the JS `createControls` that actually populates the UA shadow root. This did not work with `adoptNode` because in that case the UA shadow root already existed and was already attached to the `<video>`, so it was not called. Rather than rely on this single path to set up everything, instead have a `ControlsState` enum that `HTMLMediaElement` can internally reason about to decide whether or not it needs to inject the JS that creates `createControls` and then call it. This also has the added benefit of having those two steps now be in the same place, whereas before they were split across two unrelated functions. * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::updateCaptionContainer): (WebCore::HTMLMediaElement::virtualHasPendingActivity const): (WebCore::HTMLMediaElement::configureTextTrackDisplay): (WebCore::HTMLMediaElement::updateTextTrackDisplay): (WebCore::HTMLMediaElement::updateTextTrackRepresentationImageIfNeeded): (WebCore::HTMLMediaElement::configureMediaControls): (WebCore::HTMLMediaElement::ensureMediaControls): Added. (WebCore::HTMLMediaElement::getCurrentMediaControlsStatus): (WebCore::HTMLMediaElement::ensureMediaControlsShadowRoot): Deleted. (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Deleted. (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Deleted. * LayoutTests/media/audio-controls-adoptNode.html: Added. * LayoutTests/media/audio-controls-adoptNode-expected.txt: Added. * LayoutTests/media/video-controls-adoptNode.html: Added. * LayoutTests/media/video-controls-adoptNode-expected.txt: Added. Canonical link: https://commits.webkit.org/253225@main
webkit-early-warning-system
force-pushed
the
eng/222657
branch
from
a0c48b5
to
f331cc9
Compare
|
Committed 253225@main (f331cc9): https://commits.webkit.org/253225@main Reviewed commits have been landed. Closing PR #2955 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f331cc9