Skip to content

Use SystemV ABI for Yarr JIT on Windows#30197

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/enable-yarr-jit-win
Jun 26, 2024
Merged

Use SystemV ABI for Yarr JIT on Windows#30197
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/enable-yarr-jit-win

Conversation

@iangrunert
Copy link
Copy Markdown
Contributor

@iangrunert iangrunert commented Jun 26, 2024

778df0f

Use SystemV ABI for Yarr JIT on Windows
https://bugs.webkit.org/show_bug.cgi?id=273556

Reviewed by Yusuke Suzuki.

Also enables the following Yarr JIT features on Windows:

YARR_JIT_ALL_PARENS_EXPRESSIONS
YARR_JIT_REGEXP_TEST_INLINE
YARR_JIT_BACKREFERENCES
YARR_JIT_BACKREFERENCES_FOR_16BIT_EXPRS

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::areCanonicallyEquivalentThunkGenerator):
* Source/JavaScriptCore/yarr/YarrJIT.h:
* Source/JavaScriptCore/yarr/YarrJITRegisters.h:
(JSC::Yarr::YarrJITRegisters::validate):
* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/280393@main

261c519

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🛠 🧪 jsc 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iangrunert iangrunert requested a review from a team as a code owner June 26, 2024 18:04
Copy link
Copy Markdown
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2024
https://bugs.webkit.org/show_bug.cgi?id=273556

Reviewed by Yusuke Suzuki.

Also enables the following Yarr JIT features on Windows:

YARR_JIT_ALL_PARENS_EXPRESSIONS
YARR_JIT_REGEXP_TEST_INLINE
YARR_JIT_BACKREFERENCES
YARR_JIT_BACKREFERENCES_FOR_16BIT_EXPRS

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::areCanonicallyEquivalentThunkGenerator):
* Source/JavaScriptCore/yarr/YarrJIT.h:
* Source/JavaScriptCore/yarr/YarrJITRegisters.h:
(JSC::Yarr::YarrJITRegisters::validate):
* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/280393@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 280393@main (778df0f): https://commits.webkit.org/280393@main

Reviewed commits have been landed. Closing PR #30197 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 778df0f into WebKit:main Jun 26, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2024
@iangrunert iangrunert self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants