Skip to content

Use SystemV ABI for CSS Selector JIT on Windows#30249

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
iangrunert:ig/enable-css-jit-win
Jun 28, 2024
Merged

Use SystemV ABI for CSS Selector JIT on Windows#30249
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
iangrunert:ig/enable-css-jit-win

Conversation

@iangrunert

@iangrunert iangrunert commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

d86cd42

Use SystemV ABI for CSS Selector JIT on Windows
https://bugs.webkit.org/show_bug.cgi?id=275971

Reviewed by Yusuke Suzuki.

Dropped the OS and PLATFORM checks for CSS JIT in PlatformEnable.h, we
rely on whether JIT is enabled instead.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isCallerSavedRegister):
* Source/WebCore/cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::ruleCollectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::querySelectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::ruleCollectorSelectorCheckerWithCheckingContext):
(WebCore::SelectorCompiler::querySelectorSelectorCheckerWithCheckingContext):

Canonical link: https://commits.webkit.org/280439@main

37f126d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iangrunert iangrunert self-assigned this Jun 27, 2024

@Constellation Constellation left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 28, 2024
https://bugs.webkit.org/show_bug.cgi?id=275971

Reviewed by Yusuke Suzuki.

Dropped the OS and PLATFORM checks for CSS JIT in PlatformEnable.h, we
rely on whether JIT is enabled instead.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isCallerSavedRegister):
* Source/WebCore/cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::ruleCollectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::querySelectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::ruleCollectorSelectorCheckerWithCheckingContext):
(WebCore::SelectorCompiler::querySelectorSelectorCheckerWithCheckingContext):

Canonical link: https://commits.webkit.org/280439@main
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 280439@main (d86cd42): https://commits.webkit.org/280439@main

Reviewed commits have been landed. Closing PR #30249 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d86cd42 into WebKit:main Jun 28, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants