Skip to content

Test fixes for wasm llint on Windows#31018

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/wasm-test-failures-win
Jul 20, 2024
Merged

Test fixes for wasm llint on Windows#31018
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/wasm-test-failures-win

Conversation

@iangrunert
Copy link
Contributor

@iangrunert iangrunert commented Jul 19, 2024

6ede3d2

Test fixes for wasm llint on Windows
https://bugs.webkit.org/show_bug.cgi?id=276837

Reviewed by Yusuke Suzuki.

Four tests skipped as they rely on SIMD wasm instructions, and without
BBQ or OMG those tests fail.

exports-oom.js intermittedly fails depending on the number of arguments,
a different code path is taken in WasmLLIntPlan if the function exceeds
16 arguments. imports-oom.js previously had issues as well:
https://bugs.webkit.org/show_bug.cgi?id=196373

shared-memomry-gc-stress.js puts enough memory pressure on my system
that it'll fail and also cause surrounding tests to fail. Skipping on
Windows.

* JSTests/wasm/lowExecutableMemory/exports-oom.js:
* JSTests/wasm/stress/funcref-validation.js:
* JSTests/wasm/stress/referenced-function.js:
* JSTests/wasm/stress/try-and-block-with-v128-results.js:
* JSTests/wasm/stress/tuple-and-v128.js:
* JSTests/wasm/v8/shared-memory-gc-stress.js:

Canonical link: https://commits.webkit.org/281164@main

6fc8113

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iangrunert iangrunert requested a review from a team as a code owner July 19, 2024 21:42
@Ahmad-S792 Ahmad-S792 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jul 19, 2024
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=276837

Reviewed by Yusuke Suzuki.

Four tests skipped as they rely on SIMD wasm instructions, and without
BBQ or OMG those tests fail.

exports-oom.js intermittedly fails depending on the number of arguments,
a different code path is taken in WasmLLIntPlan if the function exceeds
16 arguments. imports-oom.js previously had issues as well:
https://bugs.webkit.org/show_bug.cgi?id=196373

shared-memomry-gc-stress.js puts enough memory pressure on my system
that it'll fail and also cause surrounding tests to fail. Skipping on
Windows.

* JSTests/wasm/lowExecutableMemory/exports-oom.js:
* JSTests/wasm/stress/funcref-validation.js:
* JSTests/wasm/stress/referenced-function.js:
* JSTests/wasm/stress/try-and-block-with-v128-results.js:
* JSTests/wasm/stress/tuple-and-v128.js:
* JSTests/wasm/v8/shared-memory-gc-stress.js:

Canonical link: https://commits.webkit.org/281164@main
@webkit-commit-queue webkit-commit-queue force-pushed the ig/wasm-test-failures-win branch from 6fc8113 to 6ede3d2 Compare July 20, 2024 05:57
@webkit-commit-queue
Copy link
Collaborator

Committed 281164@main (6ede3d2): https://commits.webkit.org/281164@main

Reviewed commits have been landed. Closing PR #31018 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6ede3d2 into WebKit:main Jul 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants