Enable Wasm BBQ JIT on Windows#31185
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jul 25, 2024
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 2e0383c) Details |
iangrunert
force-pushed
the
ig/enable-wasm-bbq-win
branch
from
2e0383c to
cde0f12
Compare
Collaborator
|
EWS run on current version of this PR (hash cde0f12) Details |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=277037 Reviewed by Yusuke Suzuki. Inside tryAllocateZeroedVirtualPages we were calling OSAllocator::reserveAndCommit which crashes if it fails to allocate, instead of tryReserveAndCommit which returns a null pointer. This caused a number of memory-related wasm test failures. * JSTests/wasm/v8/shared-memory-gc-stress.js: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJITImpl::Location::none): * Source/WTF/wtf/Gigacage.cpp: (Gigacage::tryAllocateZeroedVirtualPages): Canonical link: https://commits.webkit.org/281324@main
webkit-commit-queue
force-pushed
the
ig/enable-wasm-bbq-win
branch
from
cde0f12 to
11682f9
Compare
Collaborator
|
Committed 281324@main (11682f9): https://commits.webkit.org/281324@main Reviewed commits have been landed. Closing PR #31185 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
11682f9
cde0f12
🧪 wpe-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim