Skip to content

Conversation

@GeorgesStavracas
Copy link
Contributor

@GeorgesStavracas GeorgesStavracas commented Aug 20, 2024

f6853da

[GLIB] Add more signpost marks related to graphics
https://bugs.webkit.org/show_bug.cgi?id=278411

Reviewed by Nikolas Zimmermann.

Add a series of marks that act as submarks of BackingStoreFlush. In
particular, the important ones are the marks tile renders.

* Source/WTF/wtf/SystemTracing.h:
* Source/WTF/wtf/glib/SysprofAnnotator.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
(WebCore::CoordinatedGraphicsLayer::paintTile):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::commitSceneState):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::finalizeRenderingUpdate):

Canonical link: https://commits.webkit.org/282779@main

29893bd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@GeorgesStavracas GeorgesStavracas self-assigned this Aug 20, 2024
@GeorgesStavracas GeorgesStavracas added the WPE WebKit WebKit WPE component label Aug 20, 2024
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff -- I've been working on similar signpost messages to check the dirtyRects in the tiling code in sysprof -- great opportunity to combine the effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a compositing expert - maybe @magomez could suggest other interessting things to include here. Looks good to me.

@GeorgesStavracas GeorgesStavracas force-pushed the eng/GLIB-Add-more-signpost-marks-related-to-graphics branch from f8e52d6 to b58aa71 Compare August 21, 2024 02:27
@GeorgesStavracas GeorgesStavracas force-pushed the eng/GLIB-Add-more-signpost-marks-related-to-graphics branch from b58aa71 to b321172 Compare August 21, 2024 14:12
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@GeorgesStavracas GeorgesStavracas force-pushed the eng/GLIB-Add-more-signpost-marks-related-to-graphics branch from b321172 to 29893bd Compare August 26, 2024 19:39
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged 🥳

@carlosgcampos carlosgcampos added the merge-queue Applied to send a pull request to merge-queue label Aug 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=278411

Reviewed by Nikolas Zimmermann.

Add a series of marks that act as submarks of BackingStoreFlush. In
particular, the important ones are the marks tile renders.

* Source/WTF/wtf/SystemTracing.h:
* Source/WTF/wtf/glib/SysprofAnnotator.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
(WebCore::CoordinatedGraphicsLayer::paintTile):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::commitSceneState):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::finalizeRenderingUpdate):

Canonical link: https://commits.webkit.org/282779@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GLIB-Add-more-signpost-marks-related-to-graphics branch from 29893bd to f6853da Compare August 27, 2024 08:16
@webkit-commit-queue
Copy link
Collaborator

Committed 282779@main (f6853da): https://commits.webkit.org/282779@main

Reviewed commits have been landed. Closing PR #32478 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f6853da into WebKit:main Aug 27, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 27, 2024
@GeorgesStavracas GeorgesStavracas deleted the eng/GLIB-Add-more-signpost-marks-related-to-graphics branch August 27, 2024 13:23
@GeorgesStavracas
Copy link
Contributor Author

For documentation purposes, this PR was followed up by these commits:

@aperezdc
Copy link
Contributor

aperezdc commented Sep 3, 2024

Cherry-picked into the 2.46 branch as commit e1c6843

For documentation purposes, this PR was followed up by these commits:

...plus these two (8722cfa, 11ee713) just in case, although they are not strictly needed for our ports it's good to have them all together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants