-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[GLIB] Add more signpost marks related to graphics #32478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLIB] Add more signpost marks related to graphics #32478
Conversation
|
EWS run on previous version of this PR (hash f8e52d6) |
nikolaszimmermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff -- I've been working on similar signpost messages to check the dirtyRects in the tiling code in sysprof -- great opportunity to combine the effort.
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
Outdated
Show resolved
Hide resolved
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
Outdated
Show resolved
Hide resolved
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
Outdated
Show resolved
Hide resolved
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a compositing expert - maybe @magomez could suggest other interessting things to include here. Looks good to me.
f8e52d6 to
b58aa71
Compare
|
EWS run on previous version of this PR (hash b58aa71) |
b58aa71 to
b321172
Compare
|
EWS run on previous version of this PR (hash b321172) |
nikolaszimmermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
Outdated
Show resolved
Hide resolved
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
Outdated
Show resolved
Hide resolved
b321172 to
29893bd
Compare
|
EWS run on current version of this PR (hash 29893bd) |
nikolaszimmermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged 🥳
https://bugs.webkit.org/show_bug.cgi?id=278411 Reviewed by Nikolas Zimmermann. Add a series of marks that act as submarks of BackingStoreFlush. In particular, the important ones are the marks tile renders. * Source/WTF/wtf/SystemTracing.h: * Source/WTF/wtf/glib/SysprofAnnotator.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::updateContentBuffers): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::flushPendingLayerChanges): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::commitSceneState): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::finalizeRenderingUpdate): Canonical link: https://commits.webkit.org/282779@main
29893bd to
f6853da
Compare
|
Committed 282779@main (f6853da): https://commits.webkit.org/282779@main Reviewed commits have been landed. Closing PR #32478 and removing active labels. |
f6853da
29893bd