Skip to content

Conversation

@Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Aug 28, 2024

f4c03df

Remove Quirk hasBrokenEncryptedMediaAPISupportQuirk for starz.com
https://bugs.webkit.org/show_bug.cgi?id=278305
rdar://134237011

Reviewed by Brent Fulgham.

As part of on-going validation of old quirks, it was noted that the
following quirk is not needed, since the website continue to work (i.e.,
video playback does not throw any error). Hence, this patch removes it.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):

Canonical link: https://commits.webkit.org/282980@main

5dbd992

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 requested a review from cdumez as a code owner August 28, 2024 02:53
@Ahmad-S792 Ahmad-S792 self-assigned this Aug 28, 2024
@Ahmad-S792 Ahmad-S792 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Aug 28, 2024
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you please see if we have an existing radar to remove the quirk (for one this old we probably don't) so we can mark it off the list?

@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Aug 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=278305
rdar://134237011

Reviewed by Brent Fulgham.

As part of on-going validation of old quirks, it was noted that the
following quirk is not needed, since the website continue to work (i.e.,
video playback does not throw any error). Hence, this patch removes it.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):

Canonical link: https://commits.webkit.org/282980@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-Quirk-hasBrokenEncryptedMediaAPISupportQuirk-for-starz-com branch from 5dbd992 to f4c03df Compare August 30, 2024 18:02
@webkit-commit-queue
Copy link
Collaborator

Committed 282980@main (f4c03df): https://commits.webkit.org/282980@main

Reviewed commits have been landed. Closing PR #32793 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f4c03df into WebKit:main Aug 30, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 30, 2024
@Ahmad-S792 Ahmad-S792 deleted the eng/Remove-Quirk-hasBrokenEncryptedMediaAPISupportQuirk-for-starz-com branch August 30, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants