-
Notifications
You must be signed in to change notification settings - Fork 1.7k
dom/intersection-observer-document-leak.html is a flaky text failure #33170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
EWS run on previous version of this PR (hash 6a8ba75) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would say:
"At least 1 iframe document was destroyed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didCreated -> didCreate
6a8ba75 to
f4811b5
Compare
|
EWS run on previous version of this PR (hash f4811b5) |
f4811b5 to
89f4b19
Compare
|
EWS run on current version of this PR (hash 89f4b19) |
https://bugs.webkit.org/show_bug.cgi?id=238227 Reviewed by Chris Dumez. Due to conservative GC's property, document leak tests should create some documents to test. Open 3 windows, and pass the test if at least a single document is reclaimed. * LayoutTests/fast/dom/intersection-observer-document-leak-expected.txt: * LayoutTests/fast/dom/intersection-observer-document-leak.html: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/283244@main
89f4b19 to
50e1cf7
Compare
|
Committed 283244@main (50e1cf7): https://commits.webkit.org/283244@main Reviewed commits have been landed. Closing PR #33170 and removing active labels. |
50e1cf7
89f4b19
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-wpe🧪 ios-wk2-wpt🛠 wpe-cairo🧪 api-ios🛠 gtk🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 tv🛠 tv-sim🛠 watch🛠 watch-sim