Skip to content

Conversation

@fujii
Copy link
Contributor

@fujii fujii commented Sep 5, 2024

50e1cf7

dom/intersection-observer-document-leak.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=238227

Reviewed by Chris Dumez.

Due to conservative GC's property, document leak tests should create
some documents to test. Open 3 windows, and pass the test if at least
a single document is reclaimed.

* LayoutTests/fast/dom/intersection-observer-document-leak-expected.txt:
* LayoutTests/fast/dom/intersection-observer-document-leak.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/283244@main

89f4b19

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac 🛠 wpe 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 wincairo-tests
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
🧪 vision-wk2 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge 🛠 tv
🛠 tv-sim
🛠 watch
🛠 watch-sim

@fujii fujii requested a review from rniwa as a code owner September 5, 2024 08:20
@fujii fujii self-assigned this Sep 5, 2024
@fujii fujii added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Sep 5, 2024
@fujii fujii requested a review from cdumez September 5, 2024 19:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would say:
"At least 1 iframe document was destroyed"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didCreated -> didCreate

@fujii fujii force-pushed the eng/REGRESSIONr291523-r291501--iOS--fastdomintersection-observer-document-leak-html-is-a-flaky-text-failure branch from 6a8ba75 to f4811b5 Compare September 5, 2024 22:35
@fujii fujii force-pushed the eng/REGRESSIONr291523-r291501--iOS--fastdomintersection-observer-document-leak-html-is-a-flaky-text-failure branch from f4811b5 to 89f4b19 Compare September 6, 2024 00:07
@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=238227

Reviewed by Chris Dumez.

Due to conservative GC's property, document leak tests should create
some documents to test. Open 3 windows, and pass the test if at least
a single document is reclaimed.

* LayoutTests/fast/dom/intersection-observer-document-leak-expected.txt:
* LayoutTests/fast/dom/intersection-observer-document-leak.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/283244@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSIONr291523-r291501--iOS--fastdomintersection-observer-document-leak-html-is-a-flaky-text-failure branch from 89f4b19 to 50e1cf7 Compare September 6, 2024 00:39
@webkit-commit-queue
Copy link
Collaborator

Committed 283244@main (50e1cf7): https://commits.webkit.org/283244@main

Reviewed commits have been landed. Closing PR #33170 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 50e1cf7 into WebKit:main Sep 6, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 6, 2024
@fujii fujii deleted the eng/REGRESSIONr291523-r291501--iOS--fastdomintersection-observer-document-leak-html-is-a-flaky-text-failure branch September 10, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants