[CSS anchor positioning] WebProcess crash when popover uses anchoring#33696
Conversation
|
EWS run on previous version of this PR (hash f8395a0) Details |
f8395a0 to
40031c9
Compare
|
EWS run on previous version of this PR (hash 40031c9) Details |
40031c9 to
8c91d92
Compare
|
EWS run on previous version of this PR (hash 8c91d92) Details |
8c91d92 to
36cc3ab
Compare
|
EWS run on previous version of this PR (hash 36cc3ab) Details |
36cc3ab to
228508c
Compare
|
EWS run on previous version of this PR (hash 228508c) Details |
228508c to
fa996f6
Compare
|
EWS run on previous version of this PR (hash fa996f6) Details |
tuankiet65
left a comment
There was a problem hiding this comment.
LGTM but deferring to Antti for final review.
fa996f6 to
e96ffb3
Compare
|
EWS run on previous version of this PR (hash e96ffb3) Details |
e96ffb3 to
f169e6c
Compare
|
EWS run on current version of this PR (hash f169e6c) Details |
https://bugs.webkit.org/show_bug.cgi?id=279588 Reviewed by Antti Koivisto. When an anchor-positioned element is hidden using display:none, there's no point processing it in anchoring anymore. * LayoutTests/TestExpectations: * Source/WebCore/style/AnchorPositionEvaluator.cpp: (WebCore::Style::AnchorPositionEvaluator::evaluate): (WebCore::Style::AnchorPositionEvaluator::updateAnchorPositioningStatesAfterInterleavedLayout): Canonical link: https://commits.webkit.org/285334@main
f169e6c to
ba8e7f0
Compare
|
Committed 285334@main (ba8e7f0): https://commits.webkit.org/285334@main Reviewed commits have been landed. Closing PR #33696 and removing active labels. |
f169e6c to
ba8e7f0
Compare
|
Committed 285334@main (ba8e7f0): https://commits.webkit.org/285334@main Reviewed commits have been landed. Closing PR #33696 and removing active labels. |
ba8e7f0
f169e6c