Support CanvasRenderingContext2D.filter #3793

shallawa · 2022-08-30T00:58:25Z

`e873cb2`

Support CanvasRenderingContext2D.filter
https://bugs.webkit.org/show_bug.cgi?id=198416
rdar://51303686

Reviewed by NOBODY (OOPS!).

This implements the canvas filter API. According to the specs, the filter will
be defined as a string very similar to the CSS filter definition. An SVG filter
can be accessed via a URL like this `filter : url(#id);`.

To implement this feature without many changes in the CanvasRenderingContext2D
code, the new class FilterTargetSwitcher will be added. In its constructor we
are going to switch the rendering context to a source ImageBuffer. The next draw
commands will be drawn to this ImageBuffer. In its destructor, the filter will
be applied to the source ImageBuffer and the result will be composited back to
the original context.

Specs link: https://html.spec.whatwg.org/multipage/canvas.html#canvasfilters

* LayoutTests/fast/canvas/canvas-filter-basics-expected.txt: Added.
* LayoutTests/fast/canvas/canvas-filter-basics.html: Added.
* LayoutTests/fast/canvas/canvas-filter-bounding-rect-expected.html: Added.
* LayoutTests/fast/canvas/canvas-filter-bounding-rect.html: Added.
* LayoutTests/fast/canvas/canvas-filter-drawing-expected.html: Added.
* LayoutTests/fast/canvas/canvas-filter-drawing.html: Added.
* LayoutTests/fast/canvas/canvas-filter-repaint-rect-expected.html: Added.
* LayoutTests/fast/canvas/canvas-filter-repaint-rect.html: Added.
* LayoutTests/fast/canvas/canvas-filter-save-restore-expected.html: Added.
* LayoutTests/fast/canvas/canvas-filter-save-restore.html: Added.
* LayoutTests/fast/canvas/resources/100x100-green-rect-filter-blur.svg: Added.
* LayoutTests/fast/canvas/resources/100x100-green-rect-filter-drop-shadow.svg: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.blur.exceptions-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.discrete-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.gamma-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.identity-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.linear-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.table-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.value-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserWorkerSafe::parseFilterString):
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.h:
* Source/WebCore/html/canvas/CanvasFilterTargetSwitcher.cpp: Added.
(WebCore::CanvasFilterTargetSwitcher::CanvasFilterTargetSwitcher):
(WebCore::CanvasFilterTargetSwitcher::~CanvasFilterTargetSwitcher):
(WebCore::CanvasFilterTargetSwitcher::outsets const):
* Source/WebCore/html/canvas/CanvasFilterTargetSwitcher.h: Added.
* Source/WebCore/html/canvas/CanvasFilters.idl:
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFilterStringWithoutUpdatingStyle):
(WebCore::CanvasRenderingContext2D::createFilter const):
(WebCore::CanvasRenderingContext2D::calculateFilterOutsets const):
* Source/WebCore/html/canvas/CanvasRenderingContext2D.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::State::State):
(WebCore::CanvasRenderingContext2DBase::setFilterString):
(WebCore::CanvasRenderingContext2DBase::fillInternal):
(WebCore::CanvasRenderingContext2DBase::strokeInternal):
(WebCore::CanvasRenderingContext2DBase::fillRect):
(WebCore::CanvasRenderingContext2DBase::strokeRect):
(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::drawingContext const):
(WebCore::CanvasRenderingContext2DBase::inflatedStrokeRect const):
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):
(WebCore::CanvasRenderingContext2DBase::inflateStrokeRect const): Deleted.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
(WebCore::CanvasRenderingContext2DBase::filterString const):
(WebCore::CanvasRenderingContext2DBase::setFilterTargetSwitcher):
(WebCore::CanvasRenderingContext2DBase::createFilter const):
(WebCore::CanvasRenderingContext2DBase::calculateFilterOutsets const):
(WebCore::CanvasRenderingContext2DBase::setFilterStringWithoutUpdatingStyle):
* Source/WebCore/platform/graphics/FloatRect.h:
(WebCore::operator+):
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::copyState):
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/GraphicsContextState.cpp:
(WebCore::GraphicsContextState::mergeAllChanges):
(WebCore::GraphicsContextState::copyChanges):
* Source/WebCore/platform/graphics/GraphicsContextState.h:

e873cb2

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-08-30T01:00:25Z

EWS run on previous version of this PR (hash a8c57ff)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-08-30T17:12:44Z

EWS run on previous version of this PR (hash a4e5558)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-14T00:35:50Z

EWS run on previous version of this PR (hash ee56e3d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-14T18:54:20Z

EWS run on previous version of this PR (hash e874780)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-16T23:32:25Z

EWS run on previous version of this PR (hash 7a2a1cc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-17T00:08:05Z

EWS run on previous version of this PR (hash 9b0fc35)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-17T21:38:55Z

EWS run on previous version of this PR (hash 674c212)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

MAKIO135 · 2023-01-31T14:53:27Z

any ETA?

AugustusZ · 2023-04-14T20:06:46Z

Any updates on this? Thanks

webkit-early-warning-system · 2023-07-01T01:35:27Z

EWS run on previous version of this PR (hash f565fdd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-07-01T15:49:45Z

EWS run on previous version of this PR (hash 30e431f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=198416 rdar://51303686 Reviewed by NOBODY (OOPS!). This implements the canvas filter API. According to the specs, the filter will be defined as a string very similar to the CSS filter definition. An SVG filter can be accessed via a URL like this `filter : url(#id);`. To implement this feature without many changes in the CanvasRenderingContext2D code, the new class FilterTargetSwitcher will be added. In its constructor we are going to switch the rendering context to a source ImageBuffer. The next draw commands will be drawn to this ImageBuffer. In its destructor, the filter will be applied to the source ImageBuffer and the result will be composited back to the original context. Specs link: https://html.spec.whatwg.org/multipage/canvas.html#canvasfilters * LayoutTests/fast/canvas/canvas-filter-basics-expected.txt: Added. * LayoutTests/fast/canvas/canvas-filter-basics.html: Added. * LayoutTests/fast/canvas/canvas-filter-bounding-rect-expected.html: Added. * LayoutTests/fast/canvas/canvas-filter-bounding-rect.html: Added. * LayoutTests/fast/canvas/canvas-filter-drawing-expected.html: Added. * LayoutTests/fast/canvas/canvas-filter-drawing.html: Added. * LayoutTests/fast/canvas/canvas-filter-repaint-rect-expected.html: Added. * LayoutTests/fast/canvas/canvas-filter-repaint-rect.html: Added. * LayoutTests/fast/canvas/canvas-filter-save-restore-expected.html: Added. * LayoutTests/fast/canvas/canvas-filter-save-restore.html: Added. * LayoutTests/fast/canvas/resources/100x100-green-rect-filter-blur.svg: Added. * LayoutTests/fast/canvas/resources/100x100-green-rect-filter-drop-shadow.svg: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.blur.exceptions-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.discrete-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.gamma-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.identity-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.linear-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.table-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.canvasFilterObject.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/filters/2d.filter.value-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserWorkerSafe::parseFilterString): * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.h: * Source/WebCore/html/canvas/CanvasFilterTargetSwitcher.cpp: Added. (WebCore::CanvasFilterTargetSwitcher::CanvasFilterTargetSwitcher): (WebCore::CanvasFilterTargetSwitcher::~CanvasFilterTargetSwitcher): (WebCore::CanvasFilterTargetSwitcher::outsets const): * Source/WebCore/html/canvas/CanvasFilterTargetSwitcher.h: Added. * Source/WebCore/html/canvas/CanvasFilters.idl: * Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFilterStringWithoutUpdatingStyle): (WebCore::CanvasRenderingContext2D::createFilter const): (WebCore::CanvasRenderingContext2D::calculateFilterOutsets const): * Source/WebCore/html/canvas/CanvasRenderingContext2D.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::State::State): (WebCore::CanvasRenderingContext2DBase::setFilterString): (WebCore::CanvasRenderingContext2DBase::fillInternal): (WebCore::CanvasRenderingContext2DBase::strokeInternal): (WebCore::CanvasRenderingContext2DBase::fillRect): (WebCore::CanvasRenderingContext2DBase::strokeRect): (WebCore::CanvasRenderingContext2DBase::drawImage): (WebCore::CanvasRenderingContext2DBase::drawingContext const): (WebCore::CanvasRenderingContext2DBase::inflatedStrokeRect const): (WebCore::CanvasRenderingContext2DBase::drawTextUnchecked): (WebCore::CanvasRenderingContext2DBase::inflateStrokeRect const): Deleted. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h: (WebCore::CanvasRenderingContext2DBase::filterString const): (WebCore::CanvasRenderingContext2DBase::setFilterTargetSwitcher): (WebCore::CanvasRenderingContext2DBase::createFilter const): (WebCore::CanvasRenderingContext2DBase::calculateFilterOutsets const): (WebCore::CanvasRenderingContext2DBase::setFilterStringWithoutUpdatingStyle): * Source/WebCore/platform/graphics/FloatRect.h: (WebCore::operator+): * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::copyState): * Source/WebCore/platform/graphics/GraphicsContext.h: * Source/WebCore/platform/graphics/GraphicsContextState.cpp: (WebCore::GraphicsContextState::mergeAllChanges): (WebCore::GraphicsContextState::copyChanges): * Source/WebCore/platform/graphics/GraphicsContextState.h:

webkit-early-warning-system · 2023-07-01T16:27:11Z

EWS run on current version of this PR (hash e873cb2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

mercuryVM · 2024-01-07T15:21:47Z

Any updates?

shallawa requested review from cdumez and rniwa as code owners August 30, 2022 00:58

shallawa self-assigned this Aug 30, 2022

shallawa added Canvas Bugs related to the canvas element. WebKit Nightly Build labels Aug 30, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 30, 2022

shallawa removed the merging-blocked Applied to prevent a change from being merged label Aug 30, 2022

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from a8c57ff to a4e5558 Compare August 30, 2022 17:10

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 30, 2022

shallawa marked this pull request as draft August 30, 2022 22:22

tomayac mentioned this pull request Aug 31, 2022

Canvas2D Filters whatwg/html#5621

Open

shallawa removed the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from a4e5558 to ee56e3d Compare October 14, 2022 00:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

shallawa removed the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from ee56e3d to e874780 Compare October 14, 2022 18:51

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

shallawa removed the merging-blocked Applied to prevent a change from being merged label Oct 16, 2022

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from e874780 to 7a2a1cc Compare October 16, 2022 23:32

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from 7a2a1cc to 9b0fc35 Compare October 17, 2022 00:07

shallawa requested review from smfr, grorg and weinig October 17, 2022 00:09

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 17, 2022

shallawa requested a review from anttijk October 17, 2022 04:03

shallawa removed the merging-blocked Applied to prevent a change from being merged label Oct 17, 2022

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from 9b0fc35 to 674c212 Compare October 17, 2022 21:38

shallawa requested a review from litherum October 17, 2022 23:05

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 18, 2022

xeenon removed the WebKit Nightly Build label Nov 21, 2022

shallawa removed the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from 674c212 to f565fdd Compare July 1, 2023 01:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

shallawa removed the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from f565fdd to 30e431f Compare July 1, 2023 15:49

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

shallawa removed the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

shallawa force-pushed the eng/Support-CanvasRenderingContext2D-filter branch from 30e431f to e873cb2 Compare July 1, 2023 16:27

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support CanvasRenderingContext2D.filter #3793

Support CanvasRenderingContext2D.filter #3793

shallawa commented Aug 30, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Aug 30, 2022 •

edited

webkit-early-warning-system commented Aug 30, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

webkit-early-warning-system commented Oct 16, 2022 •

edited

webkit-early-warning-system commented Oct 17, 2022 •

edited

webkit-early-warning-system commented Oct 17, 2022 •

edited

MAKIO135 commented Jan 31, 2023

AugustusZ commented Apr 14, 2023

webkit-early-warning-system commented Jul 1, 2023 •

edited

webkit-early-warning-system commented Jul 1, 2023 •

edited

webkit-early-warning-system commented Jul 1, 2023 •

edited

mercuryVM commented Jan 7, 2024

Support CanvasRenderingContext2D.filter #3793

Are you sure you want to change the base?

Support CanvasRenderingContext2D.filter #3793

Conversation

shallawa commented Aug 30, 2022 • edited by webkit-early-warning-system

e873cb2

webkit-early-warning-system commented Aug 30, 2022 • edited

webkit-early-warning-system commented Aug 30, 2022 • edited

webkit-early-warning-system commented Oct 14, 2022 • edited

webkit-early-warning-system commented Oct 14, 2022 • edited

webkit-early-warning-system commented Oct 16, 2022 • edited

webkit-early-warning-system commented Oct 17, 2022 • edited

webkit-early-warning-system commented Oct 17, 2022 • edited

MAKIO135 commented Jan 31, 2023

AugustusZ commented Apr 14, 2023

webkit-early-warning-system commented Jul 1, 2023 • edited

webkit-early-warning-system commented Jul 1, 2023 • edited

webkit-early-warning-system commented Jul 1, 2023 • edited

mercuryVM commented Jan 7, 2024

shallawa commented Aug 30, 2022 •

edited by webkit-early-warning-system

`e873cb2`

webkit-early-warning-system commented Aug 30, 2022 •

edited

webkit-early-warning-system commented Aug 30, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

webkit-early-warning-system commented Oct 16, 2022 •

edited

webkit-early-warning-system commented Oct 17, 2022 •

edited

webkit-early-warning-system commented Oct 17, 2022 •

edited

webkit-early-warning-system commented Jul 1, 2023 •

edited

webkit-early-warning-system commented Jul 1, 2023 •

edited

webkit-early-warning-system commented Jul 1, 2023 •

edited