Skip to content

Conversation

@fantasai
Copy link
Contributor

@fantasai fantasai commented Oct 15, 2025

560b0ef

Disable auto margins in combination with position-area [css-anchor-position-1]
https://bugs.webkit.org/show_bug.cgi?id=300823

Reviewed by Alan Baradlay.

Converts auto margins to zero when position-area or anchor-center is in effect.
See w3c/csswg-drafts#10258

Tests: imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html: Rewritten.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-ref.html: Added.

web-platform-tests/wpt#55460

* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::captureInsets):

Canonical link: https://commits.webkit.org/301662@main

ded2635

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fantasai fantasai self-assigned this Oct 15, 2025
@fantasai fantasai added the Layout and Rendering For bugs with layout and rendering of Web pages. label Oct 15, 2025
@fantasai fantasai requested a review from alanbaradlay October 15, 2025 21:39
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 16, 2025
@fantasai fantasai removed the merging-blocked Applied to prevent a change from being merged label Oct 16, 2025
@fantasai fantasai force-pushed the position-area-margin-auto branch from 90d8520 to ded2635 Compare October 16, 2025 04:20
@fantasai fantasai added the merge-queue Applied to send a pull request to merge-queue label Oct 16, 2025
…sition-1]

https://bugs.webkit.org/show_bug.cgi?id=300823

Reviewed by Alan Baradlay.

Converts auto margins to zero when position-area or anchor-center is in effect.
See w3c/csswg-drafts#10258

Tests: imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html: Rewritten.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-ref.html: Added.

web-platform-tests/wpt#55460

* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::captureInsets):

Canonical link: https://commits.webkit.org/301662@main
@webkit-commit-queue
Copy link
Collaborator

Committed 301662@main (560b0ef): https://commits.webkit.org/301662@main

Reviewed commits have been landed. Closing PR #52419 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 560b0ef into WebKit:main Oct 16, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants