Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch web share's permission policy back to 'self' #6074

Merged
merged 1 commit into from Nov 11, 2022
Merged

switch web share's permission policy back to 'self' #6074

merged 1 commit into from Nov 11, 2022

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Nov 3, 2022

ded7a60

switch web share's permission policy back to 'self'
https://bugs.webkit.org/show_bug.cgi?id=247407
rdar://101893272

After agreement with other engines, everyone is hoping to switch to 'self' hopefully around the same time.
Chrome is aiming to have this in stable early next year. Firefox is already shipping.

Reviewed by Tim Horton.

* LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https-expected.txt:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https.html:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https-expected.txt:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https.html:
* LayoutTests/imported/w3c/web-platform-tests/web-share/canShare.https.html:
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html.headers: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/resources/post-message.html: Added.
* Source/WebCore/html/FeaturePolicy.cpp:
(WebCore::FeaturePolicy::parse):

Canonical link: https://commits.webkit.org/256556@main

486676b

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug ❌ πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@marcoscaceres marcoscaceres self-assigned this Nov 3, 2022
@marcoscaceres marcoscaceres added Other WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). labels Nov 3, 2022
@youennf
Copy link
Contributor

youennf commented Nov 3, 2022

After agreement with other engines, everyone is hoping to switch to 'self' hopefully around the same time.
Chrome is aiming to have this in stable early next year. Firefox is already shipping.

Should we revive the quirk policy we used to have for YouTube and twitter or is it already solved?

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 3, 2022
@marcoscaceres marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022
@marcoscaceres
Copy link
Contributor Author

Should we revive the quirk policy we used to have for YouTube and twitter or is it already solved?

That's already solved by YouTube. We've confirmed it.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022
@marcoscaceres marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022
@marcoscaceres
Copy link
Contributor Author

@marcoscaceres marcoscaceres marked this pull request as ready for review November 9, 2022 06:55
@marcoscaceres
Copy link
Contributor Author

I sent the updated WPT as a PR web-platform-tests/wpt#36862

@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 11, 2022
https://bugs.webkit.org/show_bug.cgi?id=247407
rdar://101893272

After agreement with other engines, everyone is hoping to switch to 'self' hopefully around the same time.
Chrome is aiming to have this in stable early next year. Firefox is already shipping.

Reviewed by Tim Horton.

* LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https-expected.txt:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https.html:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https-expected.txt:
* LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https.html:
* LayoutTests/imported/w3c/web-platform-tests/web-share/canShare.https.html:
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html.headers: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-share/resources/post-message.html: Added.
* Source/WebCore/html/FeaturePolicy.cpp:
(WebCore::FeaturePolicy::parse):

Canonical link: https://commits.webkit.org/256556@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256556@main (ded7a60): https://commits.webkit.org/256556@main

Reviewed commits have been landed. Closing PR #6074 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ded7a60 into WebKit:main Nov 11, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
7 participants