New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch web share's permission policy back to 'self' #6074
switch web share's permission policy back to 'self' #6074
Conversation
EWS run on previous version of this PR (hash 558778f) |
EWS run on previous version of this PR (hash 5914441) |
Should we revive the quirk policy we used to have for YouTube and twitter or is it already solved? |
EWS run on previous version of this PR (hash 9d9035f) |
.../w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub.html
Outdated
Show resolved
Hide resolved
EWS run on previous version of this PR (hash 1630317) |
That's already solved by YouTube. We've confirmed it. |
EWS run on current version of this PR (hash 486676b) |
I sent the updated WPT as a PR web-platform-tests/wpt#36862 |
https://bugs.webkit.org/show_bug.cgi?id=247407 rdar://101893272 After agreement with other engines, everyone is hoping to switch to 'self' hopefully around the same time. Chrome is aiming to have this in stable early next year. Firefox is already shipping. Reviewed by Tim Horton. * LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https-expected.txt: * LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https.html: * LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https-expected.txt: * LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https.html: * LayoutTests/imported/w3c/web-platform-tests/web-share/canShare.https.html: * LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy.https.sub.html.headers: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/feature-policy-listed.html: Added. * LayoutTests/imported/w3c/web-platform-tests/web-share/resources/post-message.html: Added. * Source/WebCore/html/FeaturePolicy.cpp: (WebCore::FeaturePolicy::parse): Canonical link: https://commits.webkit.org/256556@main
Committed 256556@main (ded7a60): https://commits.webkit.org/256556@main Reviewed commits have been landed. Closing PR #6074 and removing active labels. |
ded7a60
486676b