Animated GIF freezes when presentation attributes are changed on SVG image referenced by use element by nullhook · Pull Request #64180 · WebKit/WebKit

nullhook · 2026-05-04T17:12:33Z

`0eadba6`

Animated GIF freezes when presentation attributes are changed on SVG image referenced by use element
https://bugs.webkit.org/show_bug.cgi?id=314093
rdar://96837306

Reviewed by Said Abou-Hallawa.

When an SVG <image> element displaying an animated GIF is referenced by a
<use> element, rapidly changing a presentation attribute like opacity causes
the animation to freeze.

Each setAttribute call triggers invalidateInstances(), which rebuilds the
<use> shadow tree. The clone's renderer destruction calls
RenderImageResource::willBeDestroyed(), which unconditionally calls
stopAnimation() on the shared BitmapImage. Since the animation timer is
killed faster than the frame duration, it never fires to advance frames.

* LayoutTests/svg/custom/resources/animated-gif-for-use-test.gif: Added.
* LayoutTests/svg/custom/use-animated-image-opacity-change-expected.txt: Added.
* LayoutTests/svg/custom/use-animated-image-opacity-change.html: Added.
* Source/WebCore/rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::willBeDestroyed):

Canonical link: https://commits.webkit.org/313531@main

6085746

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	❌ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-04T17:14:13Z

EWS run on previous version of this PR (hash 0a6626a)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	❌ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2026-05-04T18:08:20Z

iOS Safer C++ Build #18044 (`0a6626a`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-ews-buildbot · 2026-05-04T18:50:36Z

macOS Safer C++ Build #99707 (`0a6626a`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2026-05-05T15:39:22Z

EWS run on previous version of this PR (hash 2afe75f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe		❌ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	❌ 🛠 ios-safer-cpp	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-05T15:56:57Z

EWS run on previous version of this PR (hash 03c5643)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	❌ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2026-05-05T16:35:29Z

iOS Safer C++ Build #18792 (`2afe75f`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-ews-buildbot · 2026-05-05T16:35:50Z

macOS Safer C++ Build #100393 (`2afe75f`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

shallawa · 2026-05-05T17:24:33Z

+{
+    CachedImage* cachedImage = nullptr;
+    if (auto* htmlImage = dynamicDowncast<HTMLImageElement>(element))
+        cachedImage = htmlImage->cachedImage();


This is awkward. We still have the other function imageFromImageElement(HTMLImageElement& element). Since the code is repeated for HTMLImageElement and SVGImageElement, cannot we use templates?

I don't think templates help here. However, we can replace imageFromImageElement and have everything go through the new imageFromElement

nullhook · 2026-05-06T13:35:59Z

One thing I've observed is that a single <img> element’s ImageLoader and its Renderer both act as CachedImage clients. As a result, when reading numberOfClients, there’s no way to distinguish between them.

This matters because if you remove a single <img> that's animating, our guard cached->numberOfClients() <= 1 is false (ImageLoader + Renderer = 2) and we'd incorrectly skip stopAnimation()

edit: I've solved this by removing the renderer as client first and then checking numberOfClients() - It still seems like an approximation but the right fix would be to return number of renderers only

webkit-early-warning-system · 2026-05-06T15:02:29Z

EWS run on previous version of this PR (hash a772916)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	❌ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-07T21:36:03Z

EWS run on previous version of this PR (hash 40f4e66)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-11T15:47:43Z

EWS run on previous version of this PR (hash 6df3aab)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		❌ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	🛠 watch-sim

webkit-early-warning-system · 2026-05-13T17:11:38Z

EWS run on previous version of this PR (hash 2de6cac)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	❌ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe		❌ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-14T13:33:26Z

EWS run on previous version of this PR (hash 76498b6)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-15T18:45:18Z

EWS run on previous version of this PR (hash 03c0aad)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-18T20:22:56Z

EWS run on previous version of this PR (hash 875a2bd)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-19T18:24:28Z

EWS run on current version of this PR (hash 6085746)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	❌ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

…image referenced by use element https://bugs.webkit.org/show_bug.cgi?id=314093 rdar://96837306 Reviewed by Said Abou-Hallawa. When an SVG <image> element displaying an animated GIF is referenced by a <use> element, rapidly changing a presentation attribute like opacity causes the animation to freeze. Each setAttribute call triggers invalidateInstances(), which rebuilds the <use> shadow tree. The clone's renderer destruction calls RenderImageResource::willBeDestroyed(), which unconditionally calls stopAnimation() on the shared BitmapImage. Since the animation timer is killed faster than the frame duration, it never fires to advance frames. * LayoutTests/svg/custom/resources/animated-gif-for-use-test.gif: Added. * LayoutTests/svg/custom/use-animated-image-opacity-change-expected.txt: Added. * LayoutTests/svg/custom/use-animated-image-opacity-change.html: Added. * Source/WebCore/rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::willBeDestroyed): Canonical link: https://commits.webkit.org/313531@main

webkit-commit-queue · 2026-05-20T00:25:49Z

Committed 313531@main (0eadba6): https://commits.webkit.org/313531@main

Reviewed commits have been landed. Closing PR #64180 and removing active labels.

nullhook self-assigned this May 4, 2026

nullhook marked this pull request as draft May 4, 2026 17:12

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 4, 2026

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 5, 2026

nullhook force-pushed the svg-use-gif-animation branch from 0a6626a to 2afe75f Compare May 5, 2026 15:37

nullhook added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 5, 2026

nullhook requested review from anttijk, shallawa and smfr May 5, 2026 15:42

nullhook marked this pull request as ready for review May 5, 2026 15:42

nullhook force-pushed the svg-use-gif-animation branch from 2afe75f to 03c5643 Compare May 5, 2026 15:56

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 5, 2026

shallawa reviewed May 5, 2026

View reviewed changes

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 6, 2026

nullhook force-pushed the svg-use-gif-animation branch from 03c5643 to a772916 Compare May 6, 2026 15:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 6, 2026

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 7, 2026

nullhook force-pushed the svg-use-gif-animation branch from a772916 to 40f4e66 Compare May 7, 2026 21:35

nullhook force-pushed the svg-use-gif-animation branch from 40f4e66 to 6df3aab Compare May 11, 2026 15:47

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 13, 2026

nullhook force-pushed the svg-use-gif-animation branch from 6df3aab to 2de6cac Compare May 13, 2026 17:11

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2026

nullhook requested a review from shallawa May 13, 2026 20:51

shallawa reviewed May 13, 2026

View reviewed changes

Comment thread Source/WebCore/testing/Internals.cpp Outdated

Comment thread Source/WebCore/rendering/RenderImageResource.cpp Outdated

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 14, 2026

nullhook force-pushed the svg-use-gif-animation branch from 2de6cac to 76498b6 Compare May 14, 2026 13:33

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 14, 2026

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 15, 2026

nullhook force-pushed the svg-use-gif-animation branch from 76498b6 to 03c0aad Compare May 15, 2026 18:45

nullhook requested a review from cdumez as a code owner May 15, 2026 18:45

nullhook requested a review from shallawa May 15, 2026 18:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 15, 2026

shallawa approved these changes May 18, 2026

View reviewed changes

Comment thread Source/WebCore/rendering/RenderImageResource.cpp Outdated

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 18, 2026

nullhook force-pushed the svg-use-gif-animation branch from 03c0aad to 875a2bd Compare May 18, 2026 20:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2026

nullhook removed the merging-blocked Applied to prevent a change from being merged label May 19, 2026

nullhook force-pushed the svg-use-gif-animation branch from 875a2bd to 6085746 Compare May 19, 2026 18:24

nullhook added the merge-queue Applied to send a pull request to merge-queue label May 20, 2026

webkit-commit-queue force-pushed the svg-use-gif-animation branch from 6085746 to 0eadba6 Compare May 20, 2026 00:25

webkit-commit-queue merged commit 0eadba6 into WebKit:main May 20, 2026

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2026

Conversation

nullhook commented May 4, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

0eadba6

Uh oh!

webkit-early-warning-system commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented May 4, 2026

iOS Safer C++ Build #18044 (0a6626a)

Uh oh!

webkit-ews-buildbot commented May 4, 2026

macOS Safer C++ Build #99707 (0a6626a)

Uh oh!

webkit-early-warning-system commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented May 5, 2026

iOS Safer C++ Build #18792 (2afe75f)

Uh oh!

webkit-ews-buildbot commented May 5, 2026

macOS Safer C++ Build #100393 (2afe75f)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shallawa May 5, 2026

Choose a reason for hiding this comment

Uh oh!

nullhook May 6, 2026

Choose a reason for hiding this comment

Uh oh!

nullhook commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

nullhook commented May 4, 2026 •

edited by webkit-early-warning-system

Loading

`0eadba6`

webkit-early-warning-system commented May 4, 2026 •

edited

Loading

iOS Safer C++ Build #18044 (`0a6626a`)

macOS Safer C++ Build #99707 (`0a6626a`)

webkit-early-warning-system commented May 5, 2026 •

edited

Loading

webkit-early-warning-system commented May 5, 2026 •

edited

Loading

iOS Safer C++ Build #18792 (`2afe75f`)

macOS Safer C++ Build #100393 (`2afe75f`)

nullhook commented May 6, 2026 •

edited

Loading

webkit-early-warning-system commented May 6, 2026 •

edited

Loading

webkit-early-warning-system commented May 7, 2026 •

edited

Loading

webkit-early-warning-system commented May 11, 2026 •

edited

Loading

webkit-early-warning-system commented May 13, 2026 •

edited

Loading

webkit-early-warning-system commented May 14, 2026 •

edited

Loading

webkit-early-warning-system commented May 15, 2026 •

edited

Loading

webkit-early-warning-system commented May 18, 2026 •

edited

Loading

webkit-early-warning-system commented May 19, 2026 •

edited

Loading