[AppKit Gestures] Only mouse tracking mode produces pointer events by aprotyas · Pull Request #64980 · WebKit/WebKit

aprotyas · 2026-05-15T08:28:35Z

`d197477`

[AppKit Gestures] Only mouse tracking mode produces pointer events
https://bugs.webkit.org/show_bug.cgi?id=314880
rdar://177139516

Reviewed by Tim Horton.

A single click via the gesture controller's synthetic click flow does
not fire pointerdown/pointerup on the page -- we only see the final
click event.

We address this issue by adding an input source check on the suppression
condition in dispatchPointerEventIfNeeded, since it is currently
short circuiting away non-iOS synthetic events that do not otherwise
have a pointer event dispatch path.

Test: AppKitGesturesTests.singleClickFiresPointerMouseAndClickEvents

* Source/WebCore/dom/Element.cpp:
(WebCore::dispatchPointerEventIfNeeded):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKitGesturesTests.swift:
(AppKitGesturesTests.singleClickFiresPointerMouseAndClickEvents(_:)):

Canonical link: https://commits.webkit.org/313371@main

f5e268a

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	~~🧪 vision-wk2~~	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-15T08:28:43Z

EWS run on previous version of this PR (hash d921ad3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

rr-codes · 2026-05-15T17:37:27Z

+        try await loadHTML()
+
+        let expectedEvents = ["pointerdown", "mousedown", "pointerup", "mouseup", "click"]
+        let jsEventList = expectedEvents.map { "\"\($0)\"" }.joined(separator: ", ")


you can use # for the string literal to avoid having to escape it

I'll try it out

rr-codes · 2026-05-15T17:37:45Z

@@ -77,6 +77,44 @@ struct AppKitGesturesTests {
        self.window.makeKeyAndOrderFront(nil)
    }

+    @Test(
+        .bug("https://webkit.org/b/314880", "Only mouse tracking mode produces pointer events")
+    )


can probably make this parameterized for content editable and not right?

Probably, I need to double check click behavior over editable content, but I'll adjust accordingly.

rr-codes · 2026-05-15T17:38:11Z

+            for (const eventType of [\(jsEventList)]) {
+                target.addEventListener(eventType, e => window.eventLog.push(e.type));
+            }
+            return null;


why does this return null

Artifact from a first draft of the test. Return isn't necessary here. I'll remove it

rr-codes · 2026-05-15T17:40:13Z

+        let eventLog = try #require(try await page.callJavaScript("return window.eventLog;") as? [String])
+
+        for eventType in expectedEvents {
+            #expect(eventLog.contains(eventType), "expected '\(eventType)' in event log: \(eventLog)")


the comment isn't necessary, Swift Testing will automatically tell you the values in the failure case

I'll fix it

rr-codes · 2026-05-15T17:41:49Z

+        await page.waitForPendingMouseEvents()
+        await page.waitForNextPresentationUpdate()
+
+        let eventLog = try #require(try await page.callJavaScript("return window.eventLog;") as? [String])


Suggested change

let eventLog = try #require(try await page.callJavaScript("return window.eventLog;") as? [String])

let eventLog = try await #require(page.callJavaScript("return window.eventLog;") as? [String])

rr-codes · 2026-05-15T17:47:16Z

+            """
+            window.eventLog = [];
+            const target = document.getElementById("div");
+            for (const eventType of [\(jsEventList)]) {


this should use a JS parameter, and use the arguments parameter to callJavaScript to populate it

webkit-early-warning-system · 2026-05-15T18:54:07Z

EWS run on previous version of this PR (hash 97e00be)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-15T22:59:20Z

EWS run on previous version of this PR (hash e031dd8)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-05-16T08:37:23Z

EWS run on current version of this PR (hash f5e268a)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	~~🧪 vision-wk2~~	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

aprotyas · 2026-05-17T01:35:40Z

Thank you for the review!

https://bugs.webkit.org/show_bug.cgi?id=314880 rdar://177139516 Reviewed by Tim Horton. A single click via the gesture controller's synthetic click flow does not fire pointerdown/pointerup on the page -- we only see the final click event. We address this issue by adding an input source check on the suppression condition in dispatchPointerEventIfNeeded, since it is currently short circuiting away non-iOS synthetic events that do not otherwise have a pointer event dispatch path. Test: AppKitGesturesTests.singleClickFiresPointerMouseAndClickEvents * Source/WebCore/dom/Element.cpp: (WebCore::dispatchPointerEventIfNeeded): * Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKitGesturesTests.swift: (AppKitGesturesTests.singleClickFiresPointerMouseAndClickEvents(_:)): Canonical link: https://commits.webkit.org/313371@main

webkit-commit-queue · 2026-05-17T01:37:37Z

Committed 313371@main (d197477): https://commits.webkit.org/313371@main

Reviewed commits have been landed. Closing PR #64980 and removing active labels.

aprotyas requested review from cdumez, rniwa and rr-codes as code owners May 15, 2026 08:28

aprotyas self-assigned this May 15, 2026

aprotyas added the UI Events For bugs related to user interactions like keyboard, mouse, and touch events. label May 15, 2026

aprotyas requested review from hortont424, lilyspiniolas, megangardner, pascoej, pxlcoder and whsieh May 15, 2026 08:29

rr-codes reviewed May 15, 2026

View reviewed changes

hortont424 approved these changes May 15, 2026

View reviewed changes

rr-codes reviewed May 15, 2026

View reviewed changes

Comment thread Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKitGesturesTests.swift Outdated

rr-codes reviewed May 15, 2026

View reviewed changes

aprotyas force-pushed the eng/314880 branch from d921ad3 to 97e00be Compare May 15, 2026 18:54

aprotyas force-pushed the eng/314880 branch from 97e00be to e031dd8 Compare May 15, 2026 22:59

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 15, 2026

aprotyas removed the merging-blocked Applied to prevent a change from being merged label May 16, 2026

aprotyas force-pushed the eng/314880 branch from e031dd8 to f5e268a Compare May 16, 2026 08:37

aprotyas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2026

webkit-commit-queue force-pushed the eng/314880 branch from f5e268a to d197477 Compare May 17, 2026 01:37

webkit-commit-queue merged commit d197477 into WebKit:main May 17, 2026

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2026

aprotyas deleted the eng/314880 branch May 17, 2026 01:41

	let eventLog = try #require(try await page.callJavaScript("return window.eventLog;") as? [String])
	let eventLog = try await #require(page.callJavaScript("return window.eventLog;") as? [String])

Conversation

aprotyas commented May 15, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aprotyas commented May 17, 2026

Uh oh!

webkit-commit-queue commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aprotyas commented May 15, 2026 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented May 15, 2026 •

edited

Loading

webkit-early-warning-system commented May 15, 2026 •

edited

Loading

webkit-early-warning-system commented May 15, 2026 •

edited

Loading

webkit-early-warning-system commented May 16, 2026 •

edited

Loading