[Site Isolation] Don't seed new RemoteFrame with the dying LocalFrame's stale FrameTreeSyncData

[zakariaridouh]

e5c4d1b

[Site Isolation] Don't seed new RemoteFrame with the dying LocalFrame's stale FrameTreeSyncData
https://bugs.webkit.org/show_bug.cgi?id=315216
rdar://177546607

Reviewed by Sihui Liu.

In WebFrame::loadDidCommitInAnotherProcess, the new RemoteFrame was
seeded with the dying LocalFrame's FrameTreeSyncData, whose
frameDocumentSecurityOrigin reflects the pre-swap document,  not
the cross-origin document the frame is navigating to. The
post-commit FrameTreeSyncDataChangedInAnotherProcess IPC arrives
shortly to refresh this, but any task that queries the remote
window in the meantime (e.g. a BroadcastChannel dispatch fired from
pagehide) can observe a cached origin that spuriously matches the
active document. BindingSecurity correctly denies the access (the
target is remote), but DOMWindow::crossDomainAccessErrorMessage
then asserts that active and target origins are not
same-origin-domain, which flakily crashes the
http/tests/site-isolation/page-lifecycle/{pagehide,pageswap,unload}.html
tests.

Seed the new RemoteFrame with an empty FrameTreeSyncData (opaque
origin) instead, matching the pattern already used by
WebFrame::createSubframe and WebFrameProxy::remoteProcessDidTerminate.
The post-commit broadcast still arrives via the same IPC connection
and supplies the real new values; until then, opaque is an honest
"unknown" placeholder that never compares same-origin.

Remove the tests from the flakey expectations.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::loadDidCommitInAnotherProcess):

Canonical link: https://commits.webkit.org/313620@main

40f024f

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win	⏳ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	🛠 ios-safer-cpp	✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	🧪 mac-intel-wk2
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 5143d10)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios		✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1d5d600)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win	⏳ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	🧪 win-tests	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash ca13404)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	🛠 win	⏳ 🛠 ios-apple
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	🧪 win-tests	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	🧪 api-mac	❌ 🧪 api-wpe		⏳ 🛠 vision-apple
	❌ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	❌ 🛠 gtk3-libwebrtc
	❌ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🛠 gtk
	❌ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	❌ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🛠 playstation
	❌ 🧪 vision-wk2	🧪 mac-intel-wk2
	❌ 🛠 tv	❌ 🛠 mac-safer-cpp
	❌ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	❌ 🛠 watch
	❌ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 40f024f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win	⏳ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	🛠 ios-safer-cpp	✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	🧪 mac-intel-wk2
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 313620@main (e5c4d1b): https://commits.webkit.org/313620@main

Reviewed commits have been landed. Closing PR #65311 and removing active labels.